Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 4959047: code review 4959047: gorun: new tool for running Go source files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by niemeyer
Modified:
14 years, 3 months ago
Reviewers:
gustavo, jp, jnml, rsc, r, r2, golang-dev, mike.rosset, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

gorun: new tool for running Go source files gorun enables running a go file from the command line, and will also cache compilations so that further runs do not have to compile the code again unless necessary. gorun caches files under a temporary directory, and ensures that concurrent runs work correctly. Unlike my previous contributions, this tool has been developed by me within time that was dedicated to Canonical Inc., and I've received written confirmation from the company that Canonical waives rights to the code, allowing me to rightfully make this donation, according to point 4 of the CLA. This code is certainly broken on windows, and will require love from a caring developer.

Patch Set 1 #

Patch Set 2 : code review 4959047: gorun: new tool for running Go source files #

Patch Set 3 : diff -r e33629f044a8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e33629f044a8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e33629f044a8 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r e33629f044a8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -0 lines) Patch
M src/cmd/Makefile View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/gorun/Makefile View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A src/cmd/gorun/doc.go View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A src/cmd/gorun/main.go View 1 2 1 chunk +255 lines, -0 lines 0 comments Download
M src/pkg/Makefile View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14
niemeyer
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 3 months ago (2011-08-31 00:26:27 UTC) #1
r
I have deep philosophical issues about this tool. Things like this have come up many ...
14 years, 3 months ago (2011-08-31 00:54:22 UTC) #2
gustavo_niemeyer.net
> I have deep philosophical issues about this tool. Things like this have > come ...
14 years, 3 months ago (2011-08-31 01:25:22 UTC) #3
jnml
On Wednesday, August 31, 2011 2:26:27 AM UTC+2, Gustavo Niemeyer wrote: > > Description: > ...
14 years, 3 months ago (2011-08-31 10:38:32 UTC) #4
gustavo_niemeyer.net
> IMHO this tool doesn't belong to the Go tree. Moreover it supports - and ...
14 years, 3 months ago (2011-08-31 13:09:07 UTC) #5
r2
Why not just put it in a public repo? -rob
14 years, 3 months ago (2011-08-31 13:17:26 UTC) #6
gustavo_niemeyer.net
> Why not just put it in a public repo? It already is, and is ...
14 years, 3 months ago (2011-08-31 13:36:26 UTC) #7
bradfitz
I still want something like this in the tree. People see me using my own ...
14 years, 3 months ago (2011-08-31 16:59:50 UTC) #8
rsc
> enough, but currently it's hg checkout + Makefiles. We don't even have a > ...
14 years, 3 months ago (2011-08-31 17:03:10 UTC) #9
bradfitz
On Wed, Aug 31, 2011 at 10:03 AM, Russ Cox <rsc@golang.org> wrote: > > enough, ...
14 years, 3 months ago (2011-08-31 17:05:49 UTC) #10
Mike.Rosset
A possible compromise is to have it in $GOROOT/misc ? Would match well with goplay ...
14 years, 3 months ago (2011-09-01 13:56:10 UTC) #11
rsc
We have goinstall precisely so that we can say no to things and still have ...
14 years, 3 months ago (2011-09-01 14:00:38 UTC) #12
niemeyer
*** Abandoned ***
14 years, 3 months ago (2011-09-03 19:04:43 UTC) #13
jp
14 years, 3 months ago (2011-09-06 12:33:41 UTC) #14
On 2011/09/03 19:04:43, niemeyer wrote:
> *** Abandoned ***

I think, even being not included into the main repository, gorun should be
discussed here and updated via CL's (at least it needs to be fixed to be used on
Windows).
Some external libraries are developed this way.
leveldb-go for example (http://codereview.appspot.com/4975057/)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b