Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2754)

Issue 4956068: Add get methods for the members in IBusAttribute for non-C language. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by fujiwara
Modified:
12 years, 9 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Add get methods for the members in IBusAttribute for non-C language. TEST=Linux desktop

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated with Message #2. #

Patch Set 3 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -6 lines) Patch
M src/ibusattribute.h View 1 3 chunks +45 lines, -6 lines 0 comments Download
M src/ibusattribute.c View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6
fujiwara
12 years, 9 months ago (2011-09-07 06:14:08 UTC) #1
Peng
http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h File src/ibusattribute.h (right): http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h#newcode144 src/ibusattribute.h:144: * @returns: An enum of IBusAttrType. #IBusAttrType http://developer.gnome.org/gtk-doc-manual/unstable/documenting_syntax.html.en If ...
12 years, 9 months ago (2011-09-08 17:45:52 UTC) #2
Peng
Hi fujiwara-san, any update for this CL? On 2011/09/08 17:45:52, Peng wrote: > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h > ...
12 years, 9 months ago (2011-09-14 13:25:42 UTC) #3
fujiwara
Sorry, I was a bit busy since yesterday was the deadline for Fedora 16 beta. ...
12 years, 9 months ago (2011-09-15 00:35:37 UTC) #4
fujiwara
On 2011/09/08 17:45:52, Peng wrote: > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h > File src/ibusattribute.h (right): > > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h#newcode144 > ...
12 years, 9 months ago (2011-09-15 06:35:32 UTC) #5
Peng
12 years, 9 months ago (2011-09-15 14:07:55 UTC) #6
LGTM. Thanks.

On 2011/09/15 06:35:32, fujiwara wrote:
> On 2011/09/08 17:45:52, Peng wrote:
> > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h
> > File src/ibusattribute.h (right):
> > 
> > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h#newcode144
> > src/ibusattribute.h:144: * @returns: An enum of IBusAttrType.
> > #IBusAttrType
> > 
> >
http://developer.gnome.org/gtk-doc-manual/unstable/documenting_syntax.html.en
> > 
> > If you could fix all gtk-doc annotation in this file, it will be perfect.
> > 
> > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h#newcode156
> > src/ibusattribute.h:156: * If the type is IBUS_ATTR_TYPE_UNDERLINE, the
return
> > value is
> > %IBUS_ATTR_TYPE_UNDERLINE
> > 
> > http://codereview.appspot.com/4956068/diff/1/src/ibusattribute.h#newcode157
> > src/ibusattribute.h:157: * IBusAttrUnderline. If the type is
> > IBUS_ATTR_TYPE_FOREGROUND,
> > ditto
> 
> Updated the patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b