Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(502)

Issue 4956058: Fix some warnings when including some Skia headers in Chromium code under VS2008. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Alexei Svitkine
Modified:
13 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix some warnings when including Skia headers in Chromium code under VS2008.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M gpu/include/GrClip.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkRect.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Alexei Svitkine
13 years, 3 months ago (2011-09-01 14:59:51 UTC) #1
bsalomon
LGTM. I'll check it in.
13 years, 3 months ago (2011-09-01 15:24:19 UTC) #2
Alexei Svitkine
Thanks! On Thu, Sep 1, 2011 at 11:24 AM, <bsalomon@google.com> wrote: > LGTM. I'll check ...
13 years, 3 months ago (2011-09-01 15:33:51 UTC) #3
bsalomon
13 years, 3 months ago (2011-09-01 15:54:11 UTC) #4
Checked in at r2209.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b