Rename to C++ Ox conventions

[chandlerc, 2011-09-08 17:40:31]

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
File include/clang/Basic/DiagnosticSemaKinds.td (right):

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1396: "mutex '%0' is still held at
the end of function '%1'">,
I would use "still locked" to avoid introducing a third term (held) into the
diagnostics

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1407: "lock '%0' is exclusive and
shared in the same scope">,
"mutex 'X' is locked exclusively and shared ..." would seem more aligned with
these messages...

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1413: "%select{reading|writing}2
variable '%0' requires lock on '%1' to be "
requires locking '%1' exclusively

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1417: "accessing variable '%0'
requires some lock">,
requires locking some mutex

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1427: "calling function '%0' requires
%select{shared|exclusive}2 lock on '%1'">,
requires locking '%1' exclusively

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1430: "cannot call function '%0'
while holding mutex '%1'">,
while mutex '%1' is locked

[supertri, 2011-09-08 21:54:48]

Since Doug LGTM'd this patch, I have committed it as is (and will shortly commit
the massive refactoring and file moving patches that followed). However, if any
of you have any additional edits, I will commit them in a follow-on patch as
soon as you are done reviewing.

[supertri, 2011-09-15 18:18:02]

Changes committed (finally).

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
File include/clang/Basic/DiagnosticSemaKinds.td (right):

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1396: "mutex '%0' is still held at
the end of function '%1'">,
On 2011/09/08 17:40:31, chandlerc wrote:
> I would use "still locked" to avoid introducing a third term (held) into the
> diagnostics

Done.

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1407: "lock '%0' is exclusive and
shared in the same scope">,
On 2011/09/08 17:40:31, chandlerc wrote:
> "mutex 'X' is locked exclusively and shared ..." would seem more aligned with
> these messages...

Done.

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1427: "calling function '%0' requires
%select{shared|exclusive}2 lock on '%1'">,
On 2011/09/08 17:40:31, chandlerc wrote:
> requires locking '%1' exclusively

Done.

http://codereview.appspot.com/4952051/diff/1/include/clang/Basic/DiagnosticSe...
include/clang/Basic/DiagnosticSemaKinds.td:1430: "cannot call function '%0'
while holding mutex '%1'">,
On 2011/09/08 17:40:31, chandlerc wrote:
> while mutex '%1' is locked

Done.