Support dead and hex key event sequence.

Support dead and hex key event sequence.

Port code from GtkSimpleContext.
Add codereview.settings

BUG=None
TEST=Linux desktop

[fujiwara, 2011-08-30 01:47:23]

LGTM

It might be better to update po/POTFILES.in.

[Peng, 2011-08-30 02:38:36]

On 2011/08/30 01:47:23, fujiwara wrote:
> LGTM
> 
> It might be better to update po/POTFILES.in.

Update POTFILES.in.

[fujiwara, 2011-08-30 02:50:06]

On 2011/08/30 02:38:36, Peng wrote:
> On 2011/08/30 01:47:23, fujiwara wrote:
> > LGTM
> > 
> > It might be better to update po/POTFILES.in.
> 
> Update POTFILES.in.

Thanks

LGTM

[fujiwara, 2011-08-30 04:27:45]

There are several build errors after I fixed the code reviews internally:

ibus-simple-engine.c: In function 'ibus_simple_engine_init':
ibus-simple-engine.c:129:5: error: 'xkbengine' undeclared (first use in this
function)
ibus-simple-engine.c:132:5: warning: implicit declaration of function '_'
[-Wimplicit-function-declaration]
ibus-simple-engine.c:154:15: error: 'IBusSimpleEngine' has no member named
'prop_list'

http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings
File xkb/codereview.settings (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings#newcode1
xkb/codereview.settings:1: # This file is used by "git cl" to get code review
information.
It is $top_srcdir/codereview.settings instead of
$top_srcdir/xkb/codereview.settings, isn't it?

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c
File xkb/ibus-engine-xkb-main.c (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c#ne...
xkb/ibus-engine-xkb-main.c:28: #include <glib/gi18n-lib.h>
Probably we can remove gi18n-lib.h here.

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c
File xkb/ibus-simple-engine.c (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c#newc...
xkb/ibus-simple-engine.c:3: #ifdef HAVE_CONDIF_H
It should be:
-#ifdef HAVE_CONDIF_H
+#ifdef HAVE_CONFIG_H

[Peng, 2011-08-30 13:44:31]

Sorry for the mistakes. Please review it again.

http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings
File xkb/codereview.settings (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings#newcode1
xkb/codereview.settings:1: # This file is used by "git cl" to get code review
information.
On 2011/08/30 04:27:45, fujiwara wrote:
> It is $top_srcdir/codereview.settings instead of
> $top_srcdir/xkb/codereview.settings, isn't it?

Done.

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c
File xkb/ibus-engine-xkb-main.c (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c#ne...
xkb/ibus-engine-xkb-main.c:28: #include <glib/gi18n-lib.h>
On 2011/08/30 04:27:45, fujiwara wrote:
> Probably we can remove gi18n-lib.h here.

I tried remove it, but build failed.

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c
File xkb/ibus-simple-engine.c (right):

http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c#newc...
xkb/ibus-simple-engine.c:3: #ifdef HAVE_CONDIF_H
On 2011/08/30 04:27:45, fujiwara wrote:
> It should be:
> -#ifdef HAVE_CONDIF_H
> +#ifdef HAVE_CONFIG_H

Done.

[fujiwara, 2011-08-31 01:14:11]

On 2011/08/30 13:44:31, Peng wrote:
> Sorry for the mistakes. Please review it again.
> 
> http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings
> File xkb/codereview.settings (right):
> 
>
http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings#newcode1
> xkb/codereview.settings:1: # This file is used by "git cl" to get code review
> information.
> On 2011/08/30 04:27:45, fujiwara wrote:
> > It is $top_srcdir/codereview.settings instead of
> > $top_srcdir/xkb/codereview.settings, isn't it?
> 
> Done.
> 
> http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c
> File xkb/ibus-engine-xkb-main.c (right):
> 
>
http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c#ne...
> xkb/ibus-engine-xkb-main.c:28: #include <glib/gi18n-lib.h>
> On 2011/08/30 04:27:45, fujiwara wrote:
> > Probably we can remove gi18n-lib.h here.
> 
> I tried remove it, but build failed.
> 
> http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c
> File xkb/ibus-simple-engine.c (right):
> 
>
http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c#newc...
> xkb/ibus-simple-engine.c:3: #ifdef HAVE_CONDIF_H
> On 2011/08/30 04:27:45, fujiwara wrote:
> > It should be:
> > -#ifdef HAVE_CONDIF_H
> > +#ifdef HAVE_CONFIG_H
> 
> Done.

LGTM
Thanks.

[fujiwara, 2011-08-31 02:06:39]

On 2011/08/31 01:14:11, fujiwara wrote:
> On 2011/08/30 13:44:31, Peng wrote:
> > Sorry for the mistakes. Please review it again.
> > 
> > http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings
> > File xkb/codereview.settings (right):
> > 
> >
>
http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings#newcode1
> > xkb/codereview.settings:1: # This file is used by "git cl" to get code
review
> > information.
> > On 2011/08/30 04:27:45, fujiwara wrote:
> > > It is $top_srcdir/codereview.settings instead of
> > > $top_srcdir/xkb/codereview.settings, isn't it?
> > 
> > Done.
> > 
> > http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c
> > File xkb/ibus-engine-xkb-main.c (right):
> > 
> >
>
http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c#ne...
> > xkb/ibus-engine-xkb-main.c:28: #include <glib/gi18n-lib.h>
> > On 2011/08/30 04:27:45, fujiwara wrote:
> > > Probably we can remove gi18n-lib.h here.
> > 
> > I tried remove it, but build failed.
> > 
> > http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c
> > File xkb/ibus-simple-engine.c (right):
> > 
> >
>
http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c#newc...
> > xkb/ibus-simple-engine.c:3: #ifdef HAVE_CONDIF_H
> > On 2011/08/30 04:27:45, fujiwara wrote:
> > > It should be:
> > > -#ifdef HAVE_CONDIF_H
> > > +#ifdef HAVE_CONFIG_H
> > 
> > Done.
> 
> LGTM
> Thanks.

I committed the patch with ibus organization.

[shawn.p.huang_gmail.com, 2011-08-31 02:24:21]

Thanks.

On Tue, Aug 30, 2011 at 10:06 PM, <takao.fujiwara1@gmail.com> wrote:

> On 2011/08/31 01:14:11, fujiwara wrote:
>
>> On 2011/08/30 13:44:31, Peng wrote:
>> > Sorry for the mistakes. Please review it again.
>> >
>> >
>>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/**
>
codereview.settings<http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings>
>
>> > File xkb/codereview.settings (right):
>> >
>> >
>>
>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/**
>
codereview.settings#newcode1<http://codereview.appspot.com/4952047/diff/5001/xkb/codereview.settings#newcode1>
>
>> > xkb/codereview.settings:1: # This file is used by "git cl" to get
>>
> code review
>
>> > information.
>> > On 2011/08/30 04:27:45, fujiwara wrote:
>> > > It is $top_srcdir/codereview.**settings instead of
>> > > $top_srcdir/xkb/codereview.**settings, isn't it?
>> >
>> > Done.
>> >
>> >
>>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/ibus-**
>
engine-xkb-main.c<http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c>
>
>> > File xkb/ibus-engine-xkb-main.c (right):
>> >
>> >
>>
>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/ibus-**
>
engine-xkb-main.c#newcode28<http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-engine-xkb-main.c#newcode28>
>
>> > xkb/ibus-engine-xkb-main.c:28: #include <glib/gi18n-lib.h>
>> > On 2011/08/30 04:27:45, fujiwara wrote:
>> > > Probably we can remove gi18n-lib.h here.
>> >
>> > I tried remove it, but build failed.
>> >
>> >
>>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/ibus-**
>
simple-engine.c<http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c>
>
>> > File xkb/ibus-simple-engine.c (right):
>> >
>> >
>>
>
> http://codereview.appspot.com/**4952047/diff/5001/xkb/ibus-**
>
simple-engine.c#newcode3<http://codereview.appspot.com/4952047/diff/5001/xkb/ibus-simple-engine.c#newcode3>
>
>> > xkb/ibus-simple-engine.c:3: #ifdef HAVE_CONDIF_H
>> > On 2011/08/30 04:27:45, fujiwara wrote:
>> > > It should be:
>> > > -#ifdef HAVE_CONDIF_H
>> > > +#ifdef HAVE_CONFIG_H
>> >
>> > Done.
>>
>
>  LGTM
>> Thanks.
>>
>
> I committed the patch with ibus organization.
>
>
>
http://codereview.appspot.com/**4952047/<http://codereview.appspot.com/4952047/>
>