Thread safety: Adding in simplified support for trylock functions

[chandlerc, 2011-09-02 06:36:48]

This seems like it may be too simplified. What does it actually do? I find the
fact that no tests are added or updated reaffirms my confusion with the nature
of the patch. Is this just cleanup?

http://codereview.appspot.com/4951054/diff/1/include/clang/Basic/Attr.td
File include/clang/Basic/Attr.td (right):

http://codereview.appspot.com/4951054/diff/1/include/clang/Basic/Attr.td#newc...
include/clang/Basic/Attr.td:598: let Args = [ExprArgument<"SuccVal">,
VariadicExprArgument<"Args">];
'SuccVal' doesn't convey any meaning to me... What is this actually doing?

http://codereview.appspot.com/4951054/diff/1/lib/Sema/AnalysisBasedWarnings.cpp
File lib/Sema/AnalysisBasedWarnings.cpp (right):

http://codereview.appspot.com/4951054/diff/1/lib/Sema/AnalysisBasedWarnings.c...
lib/Sema/AnalysisBasedWarnings.cpp:1098: // FIXME: we currently assume the
trylock succeeds and add unconditionally
This seems like a pretty glaring fixme. How useful is trylock support without
handling each branch differently?

http://codereview.appspot.com/4951054/diff/1/lib/Sema/AnalysisBasedWarnings.c...
lib/Sema/AnalysisBasedWarnings.cpp:1099: // ETLAttr->getSuccVal() will return
the first argument.
What's the relevance? We don't use that method here...

[supertri, 2011-09-02 22:24:20]

Destaging for now and committing later with the implementation for trylocks.

http://codereview.appspot.com/4951054/diff/1/include/clang/Basic/Attr.td
File include/clang/Basic/Attr.td (right):

http://codereview.appspot.com/4951054/diff/1/include/clang/Basic/Attr.td#newc...
include/clang/Basic/Attr.td:598: let Args = [ExprArgument<"SuccVal">,
VariadicExprArgument<"Args">];
On 2011/09/02 06:36:48, chandlerc wrote:
> 'SuccVal' doesn't convey any meaning to me... What is this actually doing?

Changed to "SuccessValue". From
http://clang.llvm.org/docs/LanguageExtensions.html: "The first argument is an
integer or boolean value specifying the return value of a successful lock
acquisition." Also added as comment here.