Added cedilla_compose_seqs table for pt_BR.

Added cedilla_compose_seqs table for pt_BR.


TEST=Linux desktop

[Peng, 2011-09-01 12:37:15]

http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c
File xkb/ibus-simple-engine.c (right):

http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode28
xkb/ibus-simple-engine.c:28: 
how about move it to class structure? seems all engines use same table. or maybe
use the global value is enough?

http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode168
xkb/ibus-simple-engine.c:168: gchar *ling = NULL;
lang?

http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode...
xkb/ibus-simple-engine.c:1024: if (g_ascii_strncasecmp (lang, "pt_BR", strlen
("pt_BR")) == 0) {
i think using lang to determin the current input language is not accurate. does
this table affect other language users? if not,we could always add it.

[fujiwara, 2011-09-02 04:48:06]

I updated the patch.

On 2011/09/01 12:37:15, Peng wrote:
> http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c
> File xkb/ibus-simple-engine.c (right):
> 
>
http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode28
> xkb/ibus-simple-engine.c:28: 
> how about move it to class structure? seems all engines use same table. or
maybe
> use the global value is enough?

I didn't know that usage.
I moved tables in the object to table_type in the object class.

> 
>
http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode168
> xkb/ibus-simple-engine.c:168: gchar *ling = NULL;
> lang?

I use the different meanings between ling and lang. ling is for LC_*.
But it's ok for me to use lang in this case.

> 
>
http://codereview.appspot.com/4951052/diff/1/xkb/ibus-simple-engine.c#newcode...
> xkb/ibus-simple-engine.c:1024: if (g_ascii_strncasecmp (lang, "pt_BR", strlen
> ("pt_BR")) == 0) {
> i think using lang to determin the current input language is not accurate.
does
> this table affect other language users? if not,we could always add it.

The cedilla is needed by pt-br users but this overrides the default acute.
I think almost people like to use acute so the default would be ok to check lang
by default. We may need additional customization later.

[Peng, 2011-09-02 15:23:44]

LGTM

http://codereview.appspot.com/4951052/diff/5001/xkb/ibus-simple-engine.h
File xkb/ibus-simple-engine.h (right):

http://codereview.appspot.com/4951052/diff/5001/xkb/ibus-simple-engine.h#newc...
xkb/ibus-simple-engine.h:7: #define IBUS_IS_SIMPLE_ENGINE(obj)             
(G_TYPE_CHECK_INSTANCE_TYPE ((obj), IBUS_TYPE_SIMPLE_ENGINE))
Please split it into two line as IBUS_SIMPLE_ENGINE_GET_CLASS