Issue 4951048: Add newline at end of file to get rid of warnings compiling Chromium on the Mac.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4951048: Add newline at end of file to get rid of warnings compiling Chromium on the Mac.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dmac

Modified:
13 years, 3 months ago

Reviewers:
dmaclach, Stephen White

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add newline at end of file to get rid of warnings compiling Chromium on the Mac. Chromium build wants newline at end of files. BUG=NONE TEST=BUILD

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	gpu/src/GrPathRendererChain.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dmaclach_google.com

Would you be able to patch it in, or add me as a committer, and ...

13 years, 3 months ago (2011-08-29 21:38:54 UTC) #3

Stephen White

On 2011/08/29 21:38:54, dmaclach_google.com wrote: > Would you be able to patch it in, or ...

13 years, 3 months ago (2011-08-29 21:45:54 UTC) #4

dmaclach_google.com

13 years, 3 months ago (2011-08-29 21:47:49 UTC) #5

Thank you kindly sir.

On Mon, Aug 29, 2011 at 14:45,  <senorblanco@chromium.org> wrote:
> On 2011/08/29 21:38:54, dmaclach_google.com wrote:
>>
>> Would you be able to patch it in, or add me as a committer, and I can
>
> do it.
>
> Landed as r2188.  Closing.
>
>> Cheers,
>> Dave
>
>> On Mon, Aug 29, 2011 at 14:36,  <mailto:senorblanco@chromium.org>
>
> wrote:
>>
>> > On 2011/08/29 21:33:52, dmac wrote:
>> >>
>> >> PTAL
>> >
>> > LGTM
>> >
>> > http://codereview.appspot.com/4951048/
>> >
>
>
>
> http://codereview.appspot.com/4951048/
>

Expand All Messages | Collapse All Messages