Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 4950071: Several fixes for annotate-spacing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by joeneeman
Modified:
8 years ago
Reviewers:
pkx166h, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Several fixes for annotate-spacing. - Fixes annotate-spacing to use the new spacing names. - Annotates spacing between staves as well as spacing between systems. - Fixes some collisions between annotations. - Padding (between systems, titles and staves) is properly annotated, with the annotation occuring at the horizontal position where the collision would actually happen. If the padding is the cause of the vertical spacing, it is highlighted in green.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Neil's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+419 lines, -63 lines) Patch
M lily/include/skyline.hh View 1 chunk +11 lines, -0 lines 0 comments Download
M lily/include/skyline-pair.hh View 1 chunk +2 lines, -0 lines 0 comments Download
M lily/include/system.hh View 1 chunk +3 lines, -0 lines 0 comments Download
A lily/page-layout-problem-scheme.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M lily/skyline.cc View 1 5 chunks +89 lines, -0 lines 0 comments Download
M lily/skyline-pair.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M lily/system.cc View 2 chunks +60 lines, -0 lines 0 comments Download
scm/paper-system.scm View 1 2 chunks +172 lines, -34 lines 0 comments Download
scm/stencil.scm View 1 chunk +29 lines, -29 lines 0 comments Download

Messages

Total messages: 4
pkx166h
passes make and reg tests
12 years, 6 months ago (2011-09-08 22:29:52 UTC) #1
Neil Puttock
http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc File lily/page-layout-problem-scheme.cc (right): http://codereview.appspot.com/4950071/diff/1/lily/page-layout-problem-scheme.cc#newcode26 lily/page-layout-problem-scheme.cc:26: "Return the spacing spec going between the two given ...
12 years, 6 months ago (2011-09-13 10:14:50 UTC) #2
joeneeman
Thanks, all fixed.
12 years, 6 months ago (2011-09-17 00:31:28 UTC) #3
pkx166h
12 years, 6 months ago (2011-09-24 20:02:17 UTC) #4
Passes make and reg tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b