Issue 4950069: Add extension mechanisms for custom checks to cpplint.py.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4950069: Add extension mechanisms for custom checks to cpplint.py. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Alexei Svitkine

Modified:
13 years, 3 months ago

Reviewers:
erg, Elliot Glaysher

CC:
Mark Mentovai

Base URL:
http://google-styleguide.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add extension mechanisms for custom checks to cpplint.py. This allows users of cpplint.py to specify additional check functions. Will be used by: http://codereview.chromium.org/7834045/

Patch Set 2 : '' #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
	M	cpplint/cpplint.py	View	1	8 chunks	+21 lines, -7 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Elliot Glaysher

http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py File cpplint/cpplint.py (right): http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py#newcode2921 cpplint/cpplint.py:2921: class_state, error, extra_check_functions=[]): Add to docstrings?

13 years, 3 months ago (2011-09-07 20:50:53 UTC) #2

Alexei Svitkine

13 years, 3 months ago (2011-09-07 21:05:43 UTC) #3

Elliot Glaysher

thank you, that was what I was looking for. will commit momentarily.

13 years, 3 months ago (2011-09-07 21:06:40 UTC) #4

Elliot Glaysher

On 2011/09/07 21:06:40, Elliot Glaysher wrote: > thank you, that was what I was looking ...

13 years, 3 months ago (2011-09-07 21:19:30 UTC) #5

Alexei Svitkine

13 years, 3 months ago (2011-09-07 21:29:31 UTC) #6

On 2011/09/07 21:19:30, Elliot Glaysher wrote:
> On 2011/09/07 21:06:40, Elliot Glaysher wrote:
> > thank you, that was what I was looking for. will commit momentarily.
> 
> (I can't close this issue; can you?)

Closed.

Expand All Messages | Collapse All Messages