Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1833)

Issue 4950069: Add extension mechanisms for custom checks to cpplint.py. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Alexei Svitkine
Modified:
13 years, 2 months ago
Reviewers:
erg, Elliot Glaysher
CC:
Mark Mentovai
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add extension mechanisms for custom checks to cpplint.py. This allows users of cpplint.py to specify additional check functions. Will be used by: http://codereview.chromium.org/7834045/

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M cpplint/cpplint.py View 1 8 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 6
Alexei Svitkine
13 years, 2 months ago (2011-09-07 20:45:24 UTC) #1
Elliot Glaysher
http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py File cpplint/cpplint.py (right): http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py#newcode2921 cpplint/cpplint.py:2921: class_state, error, extra_check_functions=[]): Add to docstrings?
13 years, 2 months ago (2011-09-07 20:50:53 UTC) #2
Alexei Svitkine
http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py File cpplint/cpplint.py (right): http://codereview.appspot.com/4950069/diff/1/cpplint/cpplint.py#newcode2921 cpplint/cpplint.py:2921: class_state, error, extra_check_functions=[]): On 2011/09/07 20:50:53, Elliot Glaysher wrote: ...
13 years, 2 months ago (2011-09-07 21:05:43 UTC) #3
Elliot Glaysher
thank you, that was what I was looking for. will commit momentarily.
13 years, 2 months ago (2011-09-07 21:06:40 UTC) #4
Elliot Glaysher
On 2011/09/07 21:06:40, Elliot Glaysher wrote: > thank you, that was what I was looking ...
13 years, 2 months ago (2011-09-07 21:19:30 UTC) #5
Alexei Svitkine
13 years, 2 months ago (2011-09-07 21:29:31 UTC) #6
On 2011/09/07 21:19:30, Elliot Glaysher wrote:
> On 2011/09/07 21:06:40, Elliot Glaysher wrote:
> > thank you, that was what I was looking for. will commit momentarily.
> 
> (I can't close this issue; can you?)

Closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b