Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7323)

Issue 4950059: Update the format of default.xml to allow override. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Daiki Ueno
Modified:
12 years, 8 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

Update the format of default.xml to allow override. This patch allows value inheritance from the previous matches. With the new format: <engines> <engine> <name>*</name> <rank>0</rank> <preedit-highlight>FALSE</preedit-highlight> </engine> <engine> <name>m17n:ja:*</name> <rank>2</rank> <preedit-highlight>TRUE</preedit-highlight> </engine> <engine> <name>m17n:ja:anthy</name> <rank>1</rank> </engine> </engines> We will get preedit-highlight == TRUE and rank == 1 for m17n:ja:anthy. BUG=none TEST=manual

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -175 lines) Patch
M src/Makefile.am View 1 chunk +1 line, -2 lines 0 comments Download
M src/default.xml.in.in View 1 chunk +86 lines, -135 lines 0 comments Download
M src/engine.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/m17nutil.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/m17nutil.c View 7 chunks +30 lines, -38 lines 1 comment Download
A src/test.c View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Daiki Ueno
In Fedora, we have several options defined in default.xml. However, the current default.xml is not ...
12 years, 8 months ago (2011-09-02 06:52:18 UTC) #1
Daiki Ueno
On 2011/09/02 06:52:18, Daiki Ueno wrote: > In Fedora, we have several options defined in ...
12 years, 8 months ago (2011-09-02 06:55:40 UTC) #2
Peng
On 2011/09/02 06:55:40, Daiki Ueno wrote: > On 2011/09/02 06:52:18, Daiki Ueno wrote: > > ...
12 years, 8 months ago (2011-09-02 14:41:29 UTC) #3
Peng
http://codereview.appspot.com/4950059/diff/1/src/m17nutil.c File src/m17nutil.c (right): http://codereview.appspot.com/4950059/diff/1/src/m17nutil.c#newcode26 src/m17nutil.c:26: Please remove this empty line.
12 years, 8 months ago (2011-09-02 14:41:37 UTC) #4
Daiki Ueno
On 2011/09/02 14:41:29, Peng wrote: > BTW, I am thinking if we could add a ...
12 years, 8 months ago (2011-09-05 00:43:13 UTC) #5
Daiki Ueno
12 years, 8 months ago (2011-09-05 01:09:04 UTC) #6
On 2011/09/05 00:43:13, Daiki Ueno wrote:
> On 2011/09/02 14:41:29, Peng wrote:
> 
> > BTW, I am thinking if we could add a hide/disable option in the xml file,
and
> > then we could use it to hide some keymaps.
> 
> Maybe we could reuse <rank> element with negative value for disabled keymaps. 
> I'll prepare a CL.

Oh, we have already the code:

https://github.com/ibus/ibus-m17n/blob/master/src/m17nutil.c#L195

Do you have any keymaps in mind to be disabled by default?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b