Issue 4946041: Fix GLPrograms test when GL/Gr contexts aren't created

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4946041: Fix GLPrograms test when GL/Gr contexts aren't created (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bsalomon

Modified:
13 years, 2 months ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tests/TestClassDef.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Since this is a trivial fix and two people have mentioned it on skia-discuss I'm ...

13 years, 2 months ago (2011-08-24 03:28:03 UTC) #1

bsalomon

We might consider adding a kSkipped result in addition to the current kPassed or kFailed.

13 years, 2 months ago (2011-08-24 03:29:54 UTC) #2

epoger

13 years, 2 months ago (2011-08-24 14:54:53 UTC) #4

On 2011/08/24 03:29:54, bsalomon wrote:
> We might consider adding a kSkipped result in addition to the current kPassed
or
> kFailed.

Agreed. Filed http://code.google.com/p/skia/issues/detail?id=347 ('add kSkipped
result to tests')

Expand All Messages | Collapse All Messages