Issue 4944045: More prep work in Gr for landing AA hairline renderer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4944045: More prep work in Gr for landing AA hairline renderer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by bsalomon

Modified:
13 years, 3 months ago

Reviewers:
TomH, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : updated to allow ossaa when implemented using msaa #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -15 lines)			Patch
M	gpu/include/GrContext.h	View	1	3 chunks	+9 lines, -1 line	0 comments	Download
M	gpu/include/GrSamplerState.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrContext.cpp	View	1	4 chunks	+10 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpu.h	View		3 chunks	+14 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpuGLFixed.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

On 2011/08/23 20:23:14, reed1 wrote: > SWTH (sure, what the heck) New version allows hairlines ...

13 years, 3 months ago (2011-08-23 20:30:00 UTC) #3

TomH

LGTM modulo one bug: http://codereview.appspot.com/4944045/diff/1/gpu/src/GrGpu.h File gpu/src/GrGpu.h (right): http://codereview.appspot.com/4944045/diff/1/gpu/src/GrGpu.h#newcode194 gpu/src/GrGpu.h:194: bool supportsShaderDerivatives() const { return ...

13 years, 3 months ago (2011-08-23 20:44:08 UTC) #4

bsalomon

13 years, 3 months ago (2011-08-23 20:54:49 UTC) #5

On 2011/08/23 20:44:08, TomH wrote:
> LGTM modulo one bug:
> 
> http://codereview.appspot.com/4944045/diff/1/gpu/src/GrGpu.h
> File gpu/src/GrGpu.h (right):
> 
> http://codereview.appspot.com/4944045/diff/1/gpu/src/GrGpu.h#newcode194
> gpu/src/GrGpu.h:194: bool supportsShaderDerivatives() const { return
> fShaderSupport; }
> It seems unintuitive that all GPUs that support Shaders also support Shader
> Derivatives, but we need separate functions to tell us so?
> Edit: looks like this should be fShaderDerivativeSupport

Nice catch! Fixed that and closed with r2164.

Expand All Messages | Collapse All Messages