Issue 4942043: code review 4942043: goprotobuf: proto.Equal function for comparing protocol...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4942043: code review 4942043: goprotobuf: proto.Equal function for comparing protocol... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by dsymonds

Modified:
14 years, 2 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: proto.Equal function for comparing protocol buffers.

Patch Set 2 : diff -r 64419f22acea https://goprotobuf.googlecode.com/hg #

Patch Set 3 : diff -r 64419f22acea https://goprotobuf.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 64419f22acea https://goprotobuf.googlecode.com/hg #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+231 lines, -1 line)			Patch
M	proto/Makefile	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
A	proto/equal.go	View	1 2 3	1 chunk	+148 lines, -0 lines	0 comments	Download
A	proto/equal_test.go	View	1 2 3	1 chunk	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://goprotobuf.googlecode.com/hg

14 years, 2 months ago (2011-08-22 05:51:33 UTC) #1

LGTM after file name change http://codereview.appspot.com/4942043/diff/4001/proto/Makefile File proto/Makefile (right): http://codereview.appspot.com/4942043/diff/4001/proto/Makefile#newcode37 proto/Makefile:37: cmp.go\ s/cmp/equal/

14 years, 2 months ago (2011-08-22 05:56:08 UTC) #2

dsymonds

14 years, 2 months ago (2011-08-22 05:59:30 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=f93a04884dde ***

goprotobuf: proto.Equal function for comparing protocol buffers.

R=r
CC=golang-dev
http://codereview.appspot.com/4942043

Expand All Messages | Collapse All Messages