skia-core changes for gr aa hairline code

[bsalomon, 2011-08-22 21:19:09]

core skia changes broken out from Gr changes in:
http://codereview.appspot.com/4938047/

[reed1, 2011-08-22 21:28:16]

http://codereview.appspot.com/4940045/diff/3001/include/core/SkPoint.h
File include/core/SkPoint.h (right):

http://codereview.appspot.com/4940045/diff/3001/include/core/SkPoint.h#newcod...
include/core/SkPoint.h:365: SkScalar distanceToLineBetweenSqd(const SkPoint& a,
Lets dox this new function. I presume the line in question is [a, b]. Do we
worry about the endpoints when computing distance?

Someitmes (perhaps not this time), I think these sorts of geometric computations
are better expressed as static functions. e.g.

SkComputeDistanceSquaredToLine(SkScalar x, SkScalar y, const SkPoint line[2]);

[reed1, 2011-08-22 21:31:00]

http://codereview.appspot.com/4940045/diff/3001/include/core/SkMatrix.h
File include/core/SkMatrix.h (right):

http://codereview.appspot.com/4940045/diff/3001/include/core/SkMatrix.h#newco...
include/core/SkMatrix.h:367: /** Like mapPoints but with custom byte stride
between the points.
Lets document that stride had sure better be a multiple of 4 (sizeof SkScalar)
and possibly assert that too.

http://codereview.appspot.com/4940045/diff/3001/include/core/SkMatrix.h#newco...
include/core/SkMatrix.h:372: this->mapPoints(pts, pts, 1);
Do you think we should extend mapPoints to always take this stride parameter
(defaulting to sizeof(SkPoint)) so we don't have to call it 1-point at a time?

[bsalomon, 2011-08-23 13:32:03]

updated

http://codereview.appspot.com/4940045/diff/3001/include/core/SkMatrix.h
File include/core/SkMatrix.h (right):

http://codereview.appspot.com/4940045/diff/3001/include/core/SkMatrix.h#newco...
include/core/SkMatrix.h:372: this->mapPoints(pts, pts, 1);
On 2011/08/22 21:31:00, reed1 wrote:
> Do you think we should extend mapPoints to always take this stride parameter
> (defaulting to sizeof(SkPoint)) so we don't have to call it 1-point at a time?

Yes, I almost made that change earlier. mapPointsWithStride is used a bunch in
the gpu code.

[reed1, 2011-08-23 14:22:52]

LGTM

[bsalomon, 2011-08-23 14:39:26]

Closed with r2160.