Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 4940043: Fix 1816: Lilypond-book: Give images 1mm less linewidth (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by Reinhold
Modified:
12 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix 1816: Lilypond-book: Give images 1mm less linewidth lilypond creates images that are wider than allowed (~0.5-1mm too wide), so workaround this by removing 1mm from the linewidth. Also remove code that makes the fragment snippet option imply ragged-right. Since single-line snippets are now formatted ragged-right anyway by default in lilypond, we don't need to set this explicitly. And multi-line snippets are usually not desired to be printed ragged-right.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M Documentation/usage/lilypond-book.itely View 1 chunk +3 lines, -5 lines 0 comments Download
M python/book_snippets.py View 2 chunks +2 lines, -17 lines 4 comments Download

Messages

Total messages: 4
lemzwerg
LGTM. Perhaps you should mention that reducing the line width by 1mm is a temporary ...
12 years, 7 months ago (2011-08-22 13:10:15 UTC) #1
Reinhold
http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#newcode178 python/book_snippets.py:178: %% offset the left padding and tex2pdf needs a ...
12 years, 7 months ago (2011-08-22 13:50:48 UTC) #2
Graham Percival (old account)
http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#oldcode411 python/book_snippets.py:411: if not has_line_width: This change change be pushed now; ...
12 years, 7 months ago (2011-08-22 23:58:50 UTC) #3
Graham Percival (old account)
12 years, 7 months ago (2011-08-26 01:14:07 UTC) #4
depending on how smart git is, it might be good to rebase and upload a new draft
of this patch after
  http://codereview.appspot.com/4888046/
is pushed (currently on a 48-hour countdown)

http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py
File python/book_snippets.py (right):

http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#newcode178
python/book_snippets.py:178: %% offset the left padding and tex2pdf needs a bit
of on each side
Please add a link to
  http://code.google.com/p/lilypond/issues/detail?id=1836
in this comment.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b