Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14075)

Issue 4938044: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Reinhold
Modified:
12 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode

Patch Set 1 #

Patch Set 2 : Fix rebase to origin/master #

Patch Set 3 : Fix handling autodetection errors (wrong texi2pdf binary, not installed etc.) #

Total comments: 1

Patch Set 4 : Better warnings, don't crash if latex/texi2pdf cannot be found (use defaults) #

Patch Set 5 : Fix pt->inch/mm conversion messup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -22 lines) Patch
M python/book_latex.py View 1 2 3 2 chunks +14 lines, -5 lines 0 comments Download
M python/book_texinfo.py View 1 2 3 4 4 chunks +101 lines, -17 lines 0 comments Download
M scripts/lilypond-book.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dak
http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4938044/diff/7001/python/book_texinfo.py#newcode228 python/book_texinfo.py:228: val = float (m.group (1))/72 This would be wrong. ...
12 years, 8 months ago (2011-08-22 11:51:37 UTC) #1
Reinhold
On 2011/08/22 11:51:37, dak wrote: > python/book_texinfo.py:228: val = float (m.group (1))/72 > This would ...
12 years, 8 months ago (2011-08-22 12:30:15 UTC) #2
Graham Percival (old account)
On 2011/08/22 12:30:15, Reinhold wrote: > Now, it's clear that lilypond produces .pdf files that ...
12 years, 8 months ago (2011-08-22 23:55:52 UTC) #3
Reinhold
On 2011/08/22 23:55:52, Graham Percival wrote: > On 2011/08/22 12:30:15, Reinhold wrote: > > Now, ...
12 years, 8 months ago (2011-08-23 11:38:10 UTC) #4
Graham Percival
On Tue, Aug 23, 2011 at 11:38:10AM +0000, reinhold.kainhofer@gmail.com wrote: > On 2011/08/22 23:55:52, Graham ...
12 years, 8 months ago (2011-08-23 18:06:07 UTC) #5
Graham Percival (old account)
12 years, 8 months ago (2011-08-26 03:12:46 UTC) #6
LGTM, please push.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b