Correctly determine whether HW AA lines can be used

[bsalomon, 2011-08-23 15:21:44]

More prep for landing the aa hairline renderer.  In several places we check
whether the HW supports AA lines but not whether we can actually use them given
other state.

[reed1, 2011-08-23 15:28:03]

LGTM with rename to make the hair part clearer to a dumb reader.

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrContext.cpp
File gpu/src/GrContext.cpp (right):

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrContext.cpp#newcode634
gpu/src/GrContext.cpp:634: const GrPaint& paint,
rename to isHairlines ?

[TomH, 2011-08-23 15:36:42]

LGTM.

For the medium-term, it seems to me we're being inconsistent with
capitalization?

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrDrawTarget.cpp
File gpu/src/GrDrawTarget.cpp (right):

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrDrawTarget.cpp#newc...
gpu/src/GrDrawTarget.cpp:705: if (StageWillBeUsed(s, layout, state)) {
this->?

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrInOrderDrawBuffer.h
File gpu/src/GrInOrderDrawBuffer.h (right):

http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrInOrderDrawBuffer.h...
gpu/src/GrInOrderDrawBuffer.h:42: *                   (possible indirectly).
GrResources used with the draw
possibly

http://codereview.appspot.com/4937049/diff/6001/gpu/src/GrDrawTarget.cpp
File gpu/src/GrDrawTarget.cpp (right):

http://codereview.appspot.com/4937049/diff/6001/gpu/src/GrDrawTarget.cpp#newc...
gpu/src/GrDrawTarget.cpp:698: bool GrDrawTarget::CanDisableBlend(GrVertexLayout
layout, const DrState& state) {
Did I miss a new code prefix while I was out - Dr?

[bsalomon, 2011-08-23 15:43:48]

On 2011/08/23 15:36:42, TomH wrote:
> LGTM.
> 
> For the medium-term, it seems to me we're being inconsistent with
> capitalization?

static void UppercaseStaticFunction();
void lowercaseNonStaticFunction();


> 
> http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrDrawTarget.cpp
> File gpu/src/GrDrawTarget.cpp (right):
> 
>
http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrDrawTarget.cpp#newc...
> gpu/src/GrDrawTarget.cpp:705: if (StageWillBeUsed(s, layout, state)) {
> this->?
 
It's static. :)


> 
> http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrInOrderDrawBuffer.h
> File gpu/src/GrInOrderDrawBuffer.h (right):
> 
>
http://codereview.appspot.com/4937049/diff/2001/gpu/src/GrInOrderDrawBuffer.h...
> gpu/src/GrInOrderDrawBuffer.h:42: *                   (possible indirectly).
> GrResources used with the draw
> possibly
> 
> http://codereview.appspot.com/4937049/diff/6001/gpu/src/GrDrawTarget.cpp
> File gpu/src/GrDrawTarget.cpp (right):
> 
>
http://codereview.appspot.com/4937049/diff/6001/gpu/src/GrDrawTarget.cpp#newc...
> gpu/src/GrDrawTarget.cpp:698: bool
GrDrawTarget::CanDisableBlend(GrVertexLayout
> layout, const DrState& state) {
> Did I miss a new code prefix while I was out - Dr?

Unfortunately DrawState was #defined in some windows header, so we changed it to
DrState. There is probably a better 
name...

[bsalomon, 2011-08-23 15:49:01]

Closed with r2162