Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(315)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4936048
: Template Type Diffing
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by
rtrieu
Modified:
13 years, 3 months ago
Reviewers:
Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : Fix a crash when dealing with non-type arguments
#
Patch Set 3 : Add support for more parameter types
#
Patch Set 4 : Fix template alias support.
#
Created:
13 years, 3 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+744 lines, -1 line
)
Patch
M
include/clang/Basic/Diagnostic.h
View
1
2
2 chunks
+11 lines, -1 line
0 comments
Download
M
include/clang/Basic/DiagnosticSemaKinds.td
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
include/clang/Driver/CC1Options.td
View
1
2
1 chunk
+3 lines, -0 lines
0 comments
Download
M
include/clang/Driver/Options.td
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
include/clang/Frontend/DiagnosticOptions.h
View
1
2
2 chunks
+4 lines, -0 lines
0 comments
Download
M
include/clang/Sema/Sema.h
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
lib/Basic/Diagnostic.cpp
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
lib/Driver/Tools.cpp
View
1
2
1 chunk
+6 lines, -0 lines
0 comments
Download
M
lib/Frontend/CompilerInvocation.cpp
View
1
2
2 chunks
+6 lines, -0 lines
0 comments
Download
M
lib/Frontend/Warnings.cpp
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
lib/Sema/SemaOverload.cpp
View
1
2
1 chunk
+2 lines, -0 lines
0 comments
Download
M
lib/Sema/SemaTemplate.cpp
View
1
2
3
1 chunk
+510 lines, -0 lines
0 comments
Download
A
test/Misc/type-diff.cpp
View
1
2
3
1 chunk
+192 lines, -0 lines
0 comments
Download
Issue 4936048: Template Type Diffing
Created 13 years, 3 months ago by rtrieu
Modified 13 years, 3 months ago
Reviewers:
Base URL: https://llvm.org/svn/llvm-project/cfe/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b