Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 4928041: Remove createRenderTargetFrom3DAPIState() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bsalomon
Modified:
13 years, 1 month ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Really remove save/restore code in fbo_test (rather than just comment out) #

Patch Set 3 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -302 lines) Patch
M bench/benchmain.cpp View 1 2 6 chunks +35 lines, -10 lines 0 comments Download
M gm/gmmain.cpp View 1 2 7 chunks +29 lines, -12 lines 0 comments Download
M gpu/include/GrContext.h View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
M gpu/include/GrRenderTarget.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/src/GrContext.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/src/GrGpu.h View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
M gpu/src/GrGpu.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/src/GrGpuGL.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M gpu/src/GrGpuGL.cpp View 1 2 3 chunks +1 line, -194 lines 0 comments Download
M gpu/src/GrGpuGLShaders.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M include/utils/SkEGLContext.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 chunks +7 lines, -21 lines 0 comments Download
M src/utils/SkEGLContext_none.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/utils/mac/SkEGLContext_mac.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/utils/mesa/SkEGLContext_Mesa.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M src/utils/unix/SkEGLContext_Unix.cpp View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M src/utils/win/SkEGLContext_Win.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
bsalomon
This functionality has been a real pain to maintain. AFAIK it is only used internally. ...
13 years, 1 month ago (2011-08-19 15:18:50 UTC) #1
Stephen White
LGTM
13 years, 1 month ago (2011-08-19 16:46:44 UTC) #2
bsalomon
13 years, 1 month ago (2011-08-19 17:32:46 UTC) #3
Closed with r2144.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b