Issue 4927042: No effect cleanup in pdf code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4927042: No effect cleanup in pdf code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Chris Guillory

Modified:
13 years, 4 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

No effect cleanup in pdf code. Committed: http://code.google.com/p/skia/source/detail?r=2146

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -93 lines)			Patch
M	include/pdf/SkPDFCatalog.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	include/pdf/SkPDFStream.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View	1	5 chunks	+11 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	5 chunks	+12 lines, -8 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1	7 chunks	+17 lines, -13 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1	14 chunks	+48 lines, -25 lines	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View		7 chunks	+29 lines, -15 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View		8 chunks	+24 lines, -12 lines	0 comments	Download
M	src/pdf/SkPDFUtils.cpp	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 2

LGTM