published comments http://codereview.appspot.com/4926042/diff/4001/src/pkg/runtime/windows/amd64/sys.s File src/pkg/runtime/windows/amd64/sys.s (right): http://codereview.appspot.com/4926042/diff/4001/src/pkg/runtime/windows/amd64/sys.s#newcode43 src/pkg/runtime/windows/amd64/sys.s:43: MOVQ 24(SI), R9 is it safe to ...
12 years, 8 months ago
(2011-08-25 05:54:29 UTC)
#2
LGTM Was this prompted by something or just a simplification? http://codereview.appspot.com/4926042/diff/4001/src/pkg/runtime/windows/386/sys.s File src/pkg/runtime/windows/386/sys.s (right): http://codereview.appspot.com/4926042/diff/4001/src/pkg/runtime/windows/386/sys.s#newcode15 ...
12 years, 8 months ago
(2011-08-26 20:20:26 UTC)
#3
On 2011/08/26 20:20:26, rsc wrote: > > Was this prompted by something or just a ...
12 years, 7 months ago
(2011-08-27 13:17:51 UTC)
#5
On 2011/08/26 20:20:26, rsc wrote:
>
> Was this prompted by something or just a simplification?
>
I have used callback test from misc/cgo/test to test windows callbacks. All
tests passed, but TestCallbackPanic failed with error message "locked OS thread
on exit from TestCallbackPanic". It appears, you have implemented to call
unlockm even during panic inside callback some time ago. But we didn't do the
same for windows callbaks. So instead of chasing your tail all the time, I just
decided to use your code instead.
I like how windows stdcall asm code is simple now too. I always struggle with
asm <g>.
Alex
On 2011/08/27 14:16:08, jp wrote: > > I would change is to SP-relative Why? And ...
12 years, 7 months ago
(2011-08-29 00:11:58 UTC)
#8
On 2011/08/27 14:16:08, jp wrote:
>
> I would change is to SP-relative
Why?
And I can't do it here, because if I have 4 or less args, I don't copy them to
the stack.
Alex
Issue 4926042: code review 4926042: runtime: use cgo runtime functions to call windows syscalls
(Closed)
Created 12 years, 8 months ago by brainman
Modified 12 years, 7 months ago
Reviewers: jp
Base URL:
Comments: 8
