Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14908)

Issue 4921050: Lilypond-book: Get rid of lilyquote option, use quote instead (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by Reinhold
Modified:
12 years, 7 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Lilypond-book: Get rid of lilyquote option, use quote instead The only difference between the lilyquote and quote options so far was that with lilyquote the texinfo and doctitle was outside the example block. We didn't use quote together with those texinfo texts, so there is really no need to have both. Furthermore, those texinfo options were documented as 'obscure' options, used internally for the lilypond documentation, so this shouldn't break external scores, either.

Patch Set 1 #

Patch Set 2 : Missed one line that I had in another patch... #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M python/book_snippets.py View 1 4 chunks +3 lines, -4 lines 0 comments Download
M python/book_texinfo.py View 2 chunks +1 line, -4 lines 2 comments Download

Messages

Total messages: 3
lemzwerg
LGTM. http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py File python/book_texinfo.py (right): http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py#newcode250 python/book_texinfo.py:250: if (QUOTE in snippet.option_dict): Why parentheses? Similar lines ...
12 years, 8 months ago (2011-08-22 11:19:05 UTC) #1
Graham Percival (old account)
LGTM. Please push without waiting for a countdown. (but maybe remove the parentheses first) http://codereview.appspot.com/4921050/diff/2001/python/book_texinfo.py ...
12 years, 8 months ago (2011-08-26 01:18:00 UTC) #2
pkx166h
12 years, 7 months ago (2011-08-27 08:26:44 UTC) #3
passes make and reg tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b