Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1454)

Issue 4917041: Check if BusInputContext has an enabled engine in global input method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by fujiwara
Modified:
13 years, 4 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Check if BusInputContext has an enabled engine in global input method. BUG=RH#731610 TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M bus/ibusimpl.c View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
fujiwara
13 years, 4 months ago (2011-08-19 03:07:21 UTC) #1
Peng
http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c File bus/ibusimpl.c (right): http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c#newcode1209 bus/ibusimpl.c:1209: bus_input_context_enable (context); Maybe this change will cause a problem ...
13 years, 4 months ago (2011-08-19 03:21:25 UTC) #2
Peng
13 years, 4 months ago (2011-08-23 15:02:53 UTC) #3
LGTM
On 2011/08/19 03:21:25, Peng wrote:
> http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c
> File bus/ibusimpl.c (right):
> 
> http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c#newcode1209
> bus/ibusimpl.c:1209: bus_input_context_enable (context);
> Maybe this change will cause a problem in chromeos. I will test it and get
back
> later.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b