Issue 4917041: Check if BusInputContext has an enabled engine in global input method.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4917041: Check if BusInputContext has an enabled engine in global input method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by fujiwara

Modified:
12 years, 8 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

Description

Check if BusInputContext has an enabled engine in global input method. BUG=RH#731610 TEST=Linux desktop

Patch Set 2 : Updated with the latest master. #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	bus/ibusimpl.c	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c File bus/ibusimpl.c (right): http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c#newcode1209 bus/ibusimpl.c:1209: bus_input_context_enable (context); Maybe this change will cause a problem ...

12 years, 8 months ago (2011-08-19 03:21:25 UTC) #2

Peng

12 years, 8 months ago (2011-08-23 15:02:53 UTC) #3

LGTM
On 2011/08/19 03:21:25, Peng wrote:
> http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c
> File bus/ibusimpl.c (right):
> 
> http://codereview.appspot.com/4917041/diff/1/bus/ibusimpl.c#newcode1209
> bus/ibusimpl.c:1209: bus_input_context_enable (context);
> Maybe this change will cause a problem in chromeos. I will test it and get
back
> later.

Expand All Messages | Collapse All Messages