Simplification of GrBinHashKey

Remove the streaming functionality from GrBinHashKey. This functionality is not required (because the GrEffect design was dropped).  Streaming added unnecessary complexity, virtual overhead, dynamic allocation, multi-pass key construction, etc.  I'm ripping it all out.

BUG=http://code.google.com/p/skia/issues/detail?id=278

[junov1, 2011-08-18 15:10:55]

PTAL

[bsalomon, 2011-08-18 15:30:58]

Cleanup, yay! :) It LGTM with some minor comments.

http://codereview.appspot.com/4910045/diff/1/gpu/src/GrBinHashKey.h
File gpu/src/GrBinHashKey.h (right):

http://codereview.appspot.com/4910045/diff/1/gpu/src/GrBinHashKey.h#newcode43
gpu/src/GrBinHashKey.h:43: GrAssert(GrIsALIGN4(KeySize));
could we call it setKeyData?

http://codereview.appspot.com/4910045/diff/1/gpu/src/GrBinHashKey.h#newcode63
gpu/src/GrBinHashKey.h:63: GrAssert(fIsValid && key.fIsValid);
check hash first or has that already been done by now? (I'm just thinking that
some of program keys probably look a lot alike except for a couple bits,
possibly towards the end.

http://codereview.appspot.com/4910045/diff/1/gpu/src/gr_unittests.cpp
File gpu/src/gr_unittests.cpp (right):

http://codereview.appspot.com/4910045/diff/1/gpu/src/gr_unittests.cpp#newcode80
gpu/src/gr_unittests.cpp:80: const char* testStringA_ = "abcdABCD";
Side note: I don't think we run these tests in any automated way. I'll move
these over to the tests program that gets run on every checkin. (It's great that
you've updated it)

[junov1, 2011-08-18 18:08:17]

http://codereview.appspot.com/4910045/diff/1/gpu/src/GrBinHashKey.h
File gpu/src/GrBinHashKey.h (right):

http://codereview.appspot.com/4910045/diff/1/gpu/src/GrBinHashKey.h#newcode63
gpu/src/GrBinHashKey.h:63: GrAssert(fIsValid && key.fIsValid);
Checking the hash (for an early exit opportunity) would only be useful if we
were looking specifically for a not equal condition.  This method is used for
checking equality, and sorting, so a full key compare is mandatory.  FYI: In the
case of equality, the hashes can collide.

[bsalomon, 2011-08-18 18:12:35]

> gpu/src/GrBinHashKey.h:63: GrAssert(fIsValid && key.fIsValid);
> Checking the hash (for an early exit opportunity) would only be useful if we
> were looking specifically for a not equal condition.  This method is used for
> checking equality, and sorting, so a full key compare is mandatory.  FYI: In
the
> case of equality, the hashes can collide.

Got it, I didn't pickup on the fact that this is only used when the hashes match
and we're looking for full equality.

[bsalomon, 2011-08-18 18:59:59]

Hey Justin, This broke a bunch of builds on the skia bots. Looks like its
related to using a local enum as a template param in the unit test.

On Thu, Aug 18, 2011 at 2:12 PM, <bsalomon@google.com> wrote:

> gpu/src/GrBinHashKey.h:63: GrAssert(fIsValid && key.fIsValid);
>> Checking the hash (for an early exit opportunity) would only be useful
>>
> if we
>
>> were looking specifically for a not equal condition.  This method is
>>
> used for
>
>> checking equality, and sorting, so a full key compare is mandatory.
>>
> FYI: In the
>
>> case of equality, the hashes can collide.
>>
>
> Got it, I didn't pickup on the fact that this is only used when the
> hashes match and we're looking for full equality.
>
>
>
http://codereview.appspot.com/**4910045/<http://codereview.appspot.com/4910045/>
>