This means in when we have a drawVertices with per-vert color we'll have an extra ...
13 years, 4 months ago
(2011-08-16 19:09:28 UTC)
#1
This means in when we have a drawVertices with per-vert color we'll have an
extra copy of the colors and possibly a malloc/free. But this is a very rare
call. It's never used by WebKit.
Do we really want to specialize that much to our primary client? Code simplification - ...
13 years, 4 months ago
(2011-08-16 19:12:56 UTC)
#2
Do we really want to specialize that much to our primary client?
Code simplification - esp getting rid of templates - is good. LGTM if you're
confident about lack of other significant callers.
From what I understand SkDevice::drawVertices is a very rare call in general. Mike can correct ...
13 years, 4 months ago
(2011-08-16 19:22:18 UTC)
#3
From what I understand SkDevice::drawVertices is a very rare call in
general. Mike can correct me when he gets back if I'm wrong. But in that
case we still don't need all the generality provided by the current
drawCustomVertices now that only the colors might need a conversion.
Closed with r2124.
On Tue, Aug 16, 2011 at 3:12 PM, <tomhudson@google.com> wrote:
> Do we really want to specialize that much to our primary client?
>
> Code simplification - esp getting rid of templates - is good. LGTM if
> you're confident about lack of other significant callers.
>
>
>
http://codereview.appspot.com/**4910042/<http://codereview.appspot.com/4910042/>
>
Issue 4910042: remove GrContext::drawCustomVertices
(Closed)
Created 13 years, 4 months ago by bsalomon
Modified 13 years, 4 months ago
Reviewers: TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
