Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195)

Issue 4910042: remove GrContext::drawCustomVertices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by bsalomon
Modified:
12 years, 11 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -269 lines) Patch
M gpu/include/GrContext.h View 2 chunks +0 lines, -58 lines 0 comments Download
D gpu/include/GrContext_impl.h View 1 chunk +0 lines, -127 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +16 lines, -83 lines 0 comments Download

Messages

Total messages: 3
bsalomon
This means in when we have a drawVertices with per-vert color we'll have an extra ...
12 years, 11 months ago (2011-08-16 19:09:28 UTC) #1
TomH
Do we really want to specialize that much to our primary client? Code simplification - ...
12 years, 11 months ago (2011-08-16 19:12:56 UTC) #2
bsalomon
12 years, 11 months ago (2011-08-16 19:22:18 UTC) #3
From what I understand SkDevice::drawVertices is a very rare call in
general. Mike can correct me when he gets back if I'm wrong. But in that
case we still don't need all the generality provided by the current
drawCustomVertices now that only the colors might need a conversion.

Closed with r2124.

On Tue, Aug 16, 2011 at 3:12 PM, <tomhudson@google.com> wrote:

> Do we really want to specialize that much to our primary client?
>
> Code simplification - esp getting rid of templates - is good. LGTM if
> you're confident about lack of other significant callers.
>
>
>
http://codereview.appspot.com/**4910042/<http://codereview.appspot.com/4910042/>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b