Issue 4907046: Fix typo in optimization script and make sure errors aren't swallowed by benchmarking script

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4907046: Fix typo in optimization script and make sure errors aren't swallowed by benchmarking script (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by Roger McFarlane

Modified:
12 years, 8 months ago

Reviewers:
chrisha, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix typo in optimization script and make sure errors aren't swallowed by benchmarking script Committed: http://code.google.com/p/sawbuck/source/browse/#svn/trunk400

Patch Set 1 #

Total comments: 4

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	syzygy/scripts/benchmark/benchmark.py	View		1 chunk	+1 line, -0 lines	1 comment	Download
	M	syzygy/scripts/benchmark/optimize.py	View		2 chunks	+3 lines, -3 lines	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Roger McFarlane

PTAL http://codereview.appspot.com/4907046/diff/1/syzygy/scripts/benchmark/benchmark.py File syzygy/scripts/benchmark/benchmark.py (left): http://codereview.appspot.com/4907046/diff/1/syzygy/scripts/benchmark/benchmark.py#oldcode87 syzygy/scripts/benchmark/benchmark.py:87: logging.exception('Exception in Run.') arg ... swallowing exceptions! Fixed. ...

12 years, 8 months ago (2011-08-17 03:21:53 UTC) #1

Committed, thanks.

Expand All Messages | Collapse All Messages