See http://code.google.com/p/chromium/issues/detail?id=93000 . We've had a large number of chrome crashes due to SkCanvas::saveLayer getting ...
13 years, 2 months ago
(2011-08-16 21:53:24 UTC)
#1
See http://code.google.com/p/chromium/issues/detail?id=93000 .
We've had a large number of chrome crashes due to SkCanvas::saveLayer getting
back a NULL device. This has only happened on Windows, because this is only
happening when bitmap_platform_device_win.cc is the device being used, and
someone else already has the screen DC. bitmap_platform_device_win.cc should be
fixed at some point, but skia should at least not fault in this case.
On 2011/08/16 21:53:24, bungeman wrote: > See http://code.google.com/p/chromium/issues/detail?id=93000 . > > We've had a large ...
13 years, 2 months ago
(2011-08-17 14:42:15 UTC)
#2
On 2011/08/16 21:53:24, bungeman wrote:
> See http://code.google.com/p/chromium/issues/detail?id=93000 .
>
> We've had a large number of chrome crashes due to SkCanvas::saveLayer getting
> back a NULL device. This has only happened on Windows, because this is only
> happening when bitmap_platform_device_win.cc is the device being used, and
> someone else already has the screen DC. bitmap_platform_device_win.cc should
be
> fixed at some point, but skia should at least not fault in this case.
LGTM. Maybe an SkDebugf after later creation fails.
Issue 4907045: Canvas to handle null layer device.
(Closed)
Created 13 years, 2 months ago by bungeman
Modified 13 years, 2 months ago
Reviewers: bsalomon, reed1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
