Issue 4905054: Fix for ibus_serializable_{get,set}_attachment.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4905054: Fix for ibus_serializable_{get,set}_attachment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by horo1

Modified:
12 years, 8 months ago

Reviewers:
shawn.p.huang, Yusuke Sato, Peng

CC:
mukai1, nona1, komatsu

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

Description

Fix for ibus_serializable_{get,set}_attachment. TEST=Linux desktop

Patch Set 1 #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -11 lines)			Patch
M	src/ibusserializable.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ibusserializable.c	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	src/tests/ibus-serializable.c	View	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

horo1

This cl is related to http://codereview.appspot.com/4898056/

12 years, 8 months ago (2011-08-18 11:40:01 UTC) #1

Peng

On 2011/08/18 11:40:01, horo1 wrote: > This cl is related to http://codereview.appspot.com/4898056/ LGTM. But I ...

12 years, 8 months ago (2011-08-18 15:22:02 UTC) #2

Yusuke Sato

12 years, 8 months ago (2011-08-18 15:30:41 UTC) #3

LGTM

+1 for the step-by-step approach.

On 2011/08/18 15:22:02, Peng wrote:
> On 2011/08/18 11:40:01, horo1 wrote:
> > This cl is related to http://codereview.appspot.com/4898056/
> 
> LGTM.
> 
> But I would like to modify this API to use GVariant instead of GValue. So
third
> party could use it more convenient for complex structure and without
inheriting
> IBusSerializable.
> 
> I think we could submit this CL and create a new CL for GVariant change.

Expand All Messages | Collapse All Messages