On 2011/08/18 11:40:01, horo1 wrote: > This cl is related to http://codereview.appspot.com/4898056/ LGTM. But I ...
13 years, 4 months ago
(2011-08-18 15:22:02 UTC)
#2
On 2011/08/18 11:40:01, horo1 wrote:
> This cl is related to http://codereview.appspot.com/4898056/
LGTM.
But I would like to modify this API to use GVariant instead of GValue. So third
party could use it more convenient for complex structure and without inheriting
IBusSerializable.
I think we could submit this CL and create a new CL for GVariant change.
LGTM +1 for the step-by-step approach. On 2011/08/18 15:22:02, Peng wrote: > On 2011/08/18 11:40:01, ...
13 years, 4 months ago
(2011-08-18 15:30:41 UTC)
#3
LGTM
+1 for the step-by-step approach.
On 2011/08/18 15:22:02, Peng wrote:
> On 2011/08/18 11:40:01, horo1 wrote:
> > This cl is related to http://codereview.appspot.com/4898056/
>
> LGTM.
>
> But I would like to modify this API to use GVariant instead of GValue. So
third
> party could use it more convenient for complex structure and without
inheriting
> IBusSerializable.
>
> I think we could submit this CL and create a new CL for GVariant change.
Issue 4905054: Fix for ibus_serializable_{get,set}_attachment.
(Closed)
Created 13 years, 4 months ago by horo1
Modified 13 years, 4 months ago
Reviewers: shawn.p.huang_gmail.com, Yusuke Sato, Peng
Base URL: git://github.com/ibus/ibus.git@master
Comments: 0