Issue 4905051: Fix gm error.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4905051: Fix gm error. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by arthurhsu

Modified:
12 years, 10 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Fix gm error. Use static function to avoid deferencing null pointer.

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+199 lines, -93 lines)			Patch
M	include/core/SkAdvancedTypefaceMetrics.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	include/core/SkFontHost.h	View		8 chunks	+18 lines, -12 lines	0 comments	Download
M	include/core/SkTypeface.h	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	include/core/SkTypes.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/pdf/SkPDFFont.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkAdvancedTypefaceMetrics.cpp	View		3 chunks	+17 lines, -2 lines	0 comments	Download
M	src/core/SkTypeface.cpp	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1	9 chunks	+63 lines, -18 lines	0 comments	Download
M	src/pdf/SkPDFFontImpl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1	5 chunks	+11 lines, -4 lines	0 comments	Download
M	src/ports/SkFontHost_mac_atsui.cpp	View		14 chunks	+26 lines, -25 lines	0 comments	Download
M	src/ports/SkFontHost_mac_coretext.cpp	View	1	11 chunks	+26 lines, -24 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download

Total messages: 4

Steve VanDeBogart

I think the problem is that a NULL typeface is a valid one, see ~SkPDFFont(). ...

12 years, 10 months ago (2011-08-17 20:31:36 UTC) #2

LGTM - committed as r2134.