Issue 4904043: Add mac declarations missing from 10.5

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4904043: Add mac declarations missing from 10.5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by caryclark1

Modified:
13 years ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allow subpixel positioning/quantization to work on 10.5 as well as 10.6. The CoreGraphics function headers are missing on 10.5, although the function implmentation is in the library.

Patch Set 1 #

Patch Set 2 : fixed comment typo #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1	4 chunks	+24 lines, -7 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

13 years, 3 months ago (2011-08-15 16:59:25 UTC) #2

On 2011/08/15 16:48:53, caryclark1 wrote:

Wow, nice detective work :)

LGTM.

Expand All Messages | Collapse All Messages