Issue 4901049: Revert "Improve generation of glyph advance array." This reverts commit r2126

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4901049: Revert "Improve generation of glyph advance array." This reverts commit r2126 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Steve VanDeBogart

Modified:
12 years, 10 months ago

Reviewers:
arthurhsu

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Revert "Improve generation of glyph advance array." This reverts commit r2126 gm segfaults in font id retrieval. TBR=arthurhsu@chromium.org Committed: http://code.google.com/p/skia/source/detail?r=2128

Patch Set 1 #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -198 lines)			Patch
M	include/core/SkAdvancedTypefaceMetrics.h	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	include/core/SkFontHost.h	View	8 chunks	+12 lines, -18 lines	0 comments	Download
M	include/core/SkTypeface.h	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	include/core/SkTypes.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/pdf/SkPDFFont.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkAdvancedTypefaceMetrics.cpp	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	src/core/SkTypeface.cpp	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	9 chunks	+18 lines, -62 lines	0 comments	Download
M	src/pdf/SkPDFFontImpl.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	5 chunks	+4 lines, -11 lines	0 comments	Download
M	src/ports/SkFontHost_mac_atsui.cpp	View	14 chunks	+25 lines, -26 lines	0 comments	Download
M	src/ports/SkFontHost_mac_coretext.cpp	View	11 chunks	+24 lines, -26 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	2 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages