Issue 4899047: Add an compile option to unroll for-loops with integer indices.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4899047: Add an compile option to unroll for-loops with integer indices. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by zmo

Modified:
13 years, 3 months ago

Reviewers:
kbr1, kbr

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add an compile option to unroll for-loops with integer indices. ANGLEBUG=193 TEST=with this option, for-loops with integer indices will be unrolled. Committed: http://code.google.com/p/angleproject/source/detail?r=734

Patch Set 1 #

Total comments: 1

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -5 lines)			Patch
M	include/GLSLANG/ShaderLang.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	samples/translator/translator.cpp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/build_angle.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/Compiler.cpp	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/compiler/ForLoopUnroll.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/ForLoopUnroll.cpp	View	2 chunks	+42 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM -- how was this tested? One minor comment. http://codereview.appspot.com/4899047/diff/1/src/compiler/ForLoopUnroll.cpp File src/compiler/ForLoopUnroll.cpp (right): http://codereview.appspot.com/4899047/diff/1/src/compiler/ForLoopUnroll.cpp#newcode146 src/compiler/ForLoopUnroll.cpp:146: ...

13 years, 3 months ago (2011-08-17 18:55:38 UTC) #2

zmo

13 years, 3 months ago (2011-08-17 19:12:42 UTC) #3

On 2011/08/17 18:55:38, kbr1 wrote:
> LGTM -- how was this tested? One minor comment.

Tested manually with a few shaders with loops.

> 
> http://codereview.appspot.com/4899047/diff/1/src/compiler/ForLoopUnroll.cpp
> File src/compiler/ForLoopUnroll.cpp (right):
> 
>
http://codereview.appspot.com/4899047/diff/1/src/compiler/ForLoopUnroll.cpp#n...
> src/compiler/ForLoopUnroll.cpp:146: void
> ForLoopUnroll::MarksUnrollForLoopWithIntegerIndex(TIntermNode* root)
> The naming convention (MarksUnrollForLoopWithIntegerIndex vs. the class
> MarkUnrollForLoopWithIntegerIndex -- one letter difference) is confusing.
Could
> you make this method a verb (MarkForLoopsWithIntegerIndicesForUnrolling?) and
> the class above a noun (maybe even a briefer abbreviation,
> IntegerForLoopUnrollMarker)?

Will do.

Expand All Messages | Collapse All Messages