Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1098)

Issue 4898049: Make program unit test run clean and add it to tests program (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by bsalomon
Modified:
13 years, 4 months ago
Reviewers:
epoger, Stephen White
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : commetns #

Patch Set 3 : more linewraps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -18 lines) Patch
M gpu/src/GrGLProgram.cpp View 1 2 2 chunks +25 lines, -10 lines 0 comments Download
M gpu/src/GrGpuGLShaders.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/src/GrGpuGLShaders.cpp View 5 chunks +18 lines, -5 lines 0 comments Download
M gyp/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gyp View 1 4 chunks +6 lines, -1 line 0 comments Download
A tests/GLProgramsTest.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M tests/Test.h View 2 chunks +14 lines, -0 lines 0 comments Download
M tests/Test.cpp View 1 2 chunks +21 lines, -0 lines 0 comments Download
M tests/TestClassDef.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bsalomon
Fixes up some issues in the shader generator to make the shader unit test run ...
13 years, 4 months ago (2011-08-15 20:42:52 UTC) #1
epoger
LGTM with some optional suggestions http://codereview.appspot.com/4898049/diff/1/gpu/src/GrGLProgram.cpp File gpu/src/GrGLProgram.cpp (right): http://codereview.appspot.com/4898049/diff/1/gpu/src/GrGLProgram.cpp#newcode1273 gpu/src/GrGLProgram.cpp:1273: segments->fFSCode.appendf("\tvec4 %s = vec4(0, ...
13 years, 4 months ago (2011-08-15 21:31:42 UTC) #2
bsalomon
http://codereview.appspot.com/4898049/diff/1/gpu/src/GrGLProgram.cpp File gpu/src/GrGLProgram.cpp (right): http://codereview.appspot.com/4898049/diff/1/gpu/src/GrGLProgram.cpp#newcode1273 gpu/src/GrGLProgram.cpp:1273: segments->fFSCode.appendf("\tvec4 %s = vec4(0, 0, 0, 0);\n", sumVar.c_str()); On ...
13 years, 4 months ago (2011-08-15 21:43:21 UTC) #3
Stephen White
Cool! LGTM.
13 years, 4 months ago (2011-08-15 21:46:49 UTC) #4
bsalomon
13 years, 4 months ago (2011-08-16 15:46:27 UTC) #5
Closed with r2121
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b