Issue 4897045: Output the precision for the return type in function declarations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4897045: Output the precision for the return type in function declarations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by kbr1

Modified:
14 years ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com, Alok Priyadarshi, nicolas

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Output the precision for the return type in function declarations. Tested with GLSL ES conformance suite (which doesn't test this) and the WebGL conformance suite, which now contains tests to ensure that these constructs compile correctly. Chromium bug: http://crbug.com/86952 Committed: http://code.google.com/p/angleproject/source/detail?r=731

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/OutputGLSLBase.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Zhenyao Mo

14 years ago (2011-08-15 23:12:15 UTC) #2

On 2011/08/15 23:03:01, kbr1 wrote:
> Please review. Thanks.

LGTM.

Expand All Messages | Collapse All Messages