Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1010)

Issue 4896048: Revert "Make GrDrawTarget.h and GrPathRenderer.h be private headers" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by Steve VanDeBogart
Modified:
12 years, 9 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Revert "Make GrDrawTarget.h and GrPathRenderer.h be private headers" This reverts commit r2125 Looks like GrPathRenderer.h is used from gpu/include/GrTesselatedPathRenderer.h There also seems to be a dependency tracking problem, because r2125 didn't go red, but the next revision did. Committed: http://code.google.com/p/skia/source/detail?r=2127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1532 lines) Patch
M gpu/include/GrContext.h View 2 chunks +2 lines, -6 lines 0 comments Download
A + gpu/include/GrDrawTarget.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/include/GrPathRenderer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M gpu/src/GrContext.cpp View 3 chunks +6 lines, -7 lines 0 comments Download
D gpu/src/GrDrawTarget.h View 1 chunk +0 lines, -1260 lines 0 comments Download
M gpu/src/GrGpu.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/src/GrPathRenderer.h View 1 chunk +0 lines, -256 lines 0 comments Download
M gyp/gpu.gyp View 4 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
Steve VanDeBogart
12 years, 9 months ago (2011-08-16 23:20:45 UTC) #1
bsalomon
12 years, 9 months ago (2011-08-17 13:35:14 UTC) #2
Yikes! It built fine locally for me. I suppose gyp-gen'ed projects lose
track of dependencies when a file is removed from the gyp. I'll be sure to
do a clean build before submitting changes that move files around in the
future.

Brian

On Tue, Aug 16, 2011 at 7:20 PM, <vandebo@chromium.org> wrote:

> Reviewers: bsalomon,
>
> Description:
> Revert "Make GrDrawTarget.h and GrPathRenderer.h be private headers"
>
> This reverts commit r2125
>
> Looks like GrPathRenderer.h is used from
> gpu/include/**GrTesselatedPathRenderer.h
>
> There also seems to be a dependency tracking problem, because r2125
> didn't go red, but the next revision did.
>
> Committed:
http://code.google.com/p/skia/**source/detail?r=2127<http://code.google.com/p...
>
> Please review this at
http://codereview.appspot.com/**4896048/<http://codereview.appspot.com/4896048/>
>
> Affected files:
>  M gpu/include/GrContext.h
>  A + gpu/include/GrDrawTarget.h
>  A + gpu/include/GrPathRenderer.h
>  M gpu/src/GrContext.cpp
>  D gpu/src/GrDrawTarget.h
>  M gpu/src/GrGpu.cpp
>  D gpu/src/GrPathRenderer.h
>  M gyp/gpu.gyp
>  M samplecode/SampleApp.cpp
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b