Fix 1529: hashed snippet filename changes should not count as log differences

Fix 1529: hashed snippet filename changes should not count as log differences

If the contents of a regtest change, the regtest gets a new hash and
thus a new filename. Unfortunately, this will be detected by
output-distance as a change and will show up in the regtest analysis.
To work around this, I'm simply extracting the old and the new filename
before we compare the log files and if they differ, I replace the old
filename with the new filename in the old log file. Thus, it will
appear as if the new filename was also used in the baseline and it
will not be flagged as a difference.

[Reinhold, 2011-08-21 15:54:28]

http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):

http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py...
scripts/build/output-distance.py:481: print "Replacing old filename %s by %s" %
(m0.group(1), m1.group(1))
This debug statement will be remove before pushing, of course.

[Keith, 2011-08-23 07:36:51]

http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py
File scripts/build/output-distance.py (left):

http://codereview.appspot.com/4893044/diff/1/scripts/build/output-distance.py...
scripts/build/output-distance.py:471: import difflib
Need to keep this

[pkx166h, 2011-08-24 21:18:56]

passes make but reg test check fails

--snip--

reading input/regression/midi/out-test-baseline/key-option-midi.profile
reading input/regression/midi/out-test/key-option-midi.profile
reading input/regression/midi/out-test-baseline/tree.gittxt
reading input/regression/midi/out-test/tree.gittxt
no source for <__main__.GitFileCompareLink instance at 0xd85d80c>
Traceback (most recent call last):
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
1278, in <module>
    main ()
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
1275, in main
    compare_tree_pairs (zip (args[0::2], args[1::2]), out, options.threshold)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
990, in compare_tree_pairs
    data.print_results (threshold)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
982, in print_results
    self.write_text_result_page ('', threshold)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
926, in write_text_result_page
    (changed, below, unchanged) = self.thresholded_results (threshold)
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
908, in thresholded_results
    for link in self.file_links.values ()]
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
365, in distance
    self._distance = self.calc_distance ()
  File "/home/jlowe/lilypond-git/build/scripts/build/out/output-distance", line
487, in calc_distance
    diff = difflib.unified_diff (cont0.split ('\n'),
NameError: global name 'difflib' is not defined
make: *** [local-check] Error 1
jlowe@jlowe-lilybuntu2:~/lilypond-git/build$

[reinhold_kainhofer.com, 2011-08-24 21:53:23]

Am Wednesday, 24. August 2011, 23:18:56 schrieb pkx166h@gmail.com:
> passes make but reg test check fails

New patch uploaded, which includes the "import difflib" that I accidentally 
forgot to "git add" before uploading...

Cheers,
Reinhold
-- 
------------------------------------------------------------------
Reinhold Kainhofer, reinhold@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

[pkx166h, 2011-08-27 07:56:11]

passes make and reg tests