Issue 4887049: [http-java 1.5] bug fixes for XML parsing/serialization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4887049: [http-java 1.5] bug fixes for XML parsing/serialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by yanivi

Modified:
12 years, 8 months ago

Reviewers:
rmistry

Visibility:
Public.

Description

[Issue 23] NullPointerException when non-top-level element declares a new namespace and uses it fix a serialization bug that the XML namespace declaration was missing for the XML namespace of the top-level element

Patch Set 1 #

Total comments: 2

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -52 lines)			Patch
M	google-http-client/src/main/java/com/google/api/client/xml/Xml.java	View	5 chunks	+41 lines, -31 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java	View	3 chunks	+30 lines, -15 lines	2 comments	Download
M	google-http-client/src/test/java/com/google/api/client/xml/XmlNamespaceDictionaryTest.java	View	4 chunks	+87 lines, -4 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/xml/XmlTest.java	View	2 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/4887049/diff/1/google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java File google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java (right): http://codereview.appspot.com/4887049/diff/1/google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java#newcode301 google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java:301: * Returns the namespace alias to use for ...

12 years, 8 months ago (2011-08-22 16:53:34 UTC) #2

yanivi

12 years, 8 months ago (2011-08-22 20:28:35 UTC) #3

Submitting now.

http://codereview.appspot.com/4887049/diff/1/google-http-client/src/main/java...
File
google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java
(right):

http://codereview.appspot.com/4887049/diff/1/google-http-client/src/main/java...
google-http-client/src/main/java/com/google/api/client/xml/XmlNamespaceDictionary.java:301:
* Returns the namespace alias to use for a given namespace alias, throwing an
exception if no
On 2011/08/22 16:53:34, rmistry wrote:
> 'for a given namespace URI'

Done.

Expand All Messages | Collapse All Messages