Issue 4887042: Address lint issues in pdf directories.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4887042: Address lint issues in pdf directories. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Chris Guillory

Modified:
13 years, 4 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Address lint issues in pdf directories. Committed: http://code.google.com/p/skia/source/detail?r=2117

Patch Set 2 : '' #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -43 lines)			Patch
M	include/pdf/SkBitSet.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	include/pdf/SkPDFFont.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/pdf/SkPDFTypes.h	View	1	3 chunks	+8 lines, -8 lines	0 comments	Download
M	include/pdf/SkPDFUtils.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkBitSet.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	2 chunks	+5 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFImage.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Chris Guillory

Note: I didn't remove C-style casts in SkPDFFont.cpp or SkPDFImage.cpp.

13 years, 4 months ago (2011-08-15 19:37:04 UTC) #2

Steve VanDeBogart

LGTM w/ comment. http://codereview.appspot.com/4887042/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/4887042/diff/1/src/pdf/SkPDFDevice.cpp#newcode798 src/pdf/SkPDFDevice.cpp:798: sk_malloc_flags(numGlyphs * 2, SK_MALLOC_TEMP | SK_MALLOC_THROW)); ...

13 years, 4 months ago (2011-08-15 20:56:15 UTC) #3

Chris Guillory

http://codereview.appspot.com/4887042/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/4887042/diff/1/src/pdf/SkPDFDevice.cpp#newcode798 src/pdf/SkPDFDevice.cpp:798: sk_malloc_flags(numGlyphs * 2, SK_MALLOC_TEMP | SK_MALLOC_THROW)); On 2011/08/15 20:56:17, ...

13 years, 4 months ago (2011-08-15 22:12:40 UTC) #4

LG

Expand All Messages | Collapse All Messages