Issue 4873043: code review 4873043: net: return correct local address for an accepted TCP c...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4873043: code review 4873043: net: return correct local address for an accepted TCP c... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by mikio

Modified:
12 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: return correct local address for an accepted TCP connection Fixes issue 2127.

Patch Set 1 #

Patch Set 2 : diff -r c088a2c5eae7 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c088a2c5eae7 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c088a2c5eae7 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/pkg/net/fd.go	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2011-08-12 05:13:34 UTC) #1

rsc

I am a little confused. Why is c.fd.laddr wrong to begin with? Can we get ...

12 years, 8 months ago (2011-08-12 10:38:14 UTC) #2

mikio

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 8 months ago (2011-08-12 12:29:10 UTC) #3

mikio

On Fri, Aug 12, 2011 at 7:38 PM, Russ Cox <rsc@golang.org> wrote: > I am ...

12 years, 8 months ago (2011-08-12 12:35:06 UTC) #4

rsc

12 years, 8 months ago (2011-08-16 20:53:12 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=728c557af24a ***

net: return correct local address for an accepted TCP connection

Fixes issue 2127.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4873043

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages