Port keyval and unicode converting functions from gtk.

Port keyval and unicode converting functions from gtk.


BUG=None
TEST=None

[Yusuke Sato, 2011-08-11 14:45:39]

Could you let me know the use case of the new functions?

http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h
File src/ibuskeys.h (right):

http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h#newcode53
src/ibuskeys.h:53: guint            ibus_unicode_to_keyval (guint32         wc);
How about copying or moving the function comment in ibuskeyuni.c to this file? 

Since the return value of the function is actually confusing, I guess it's
better to have a clear documentation here.

[Peng, 2011-08-12 00:44:32]

On 2011/08/11 14:45:39, Yusuke Sato wrote:
> Could you let me know the use case of the new functions?

I plan to add compose key support in ibus-xkb-layouts. It could provide a
alternative way for resolving an xim issue
(http://code.google.com/p/ibus/issues/detail?id=526).
It needs those functions to convert keyval to unichar. And I think some engines
or immodules may need them too, so it is better to share them in libibus.

> 
> http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h
> File src/ibuskeys.h (right):
> 
> http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h#newcode53
> src/ibuskeys.h:53: guint            ibus_unicode_to_keyval (guint32        
wc);
> How about copying or moving the function comment in ibuskeyuni.c to this file?

> 
> Since the return value of the function is actually confusing, I guess it's
> better to have a clear documentation here.

[Peng, 2011-08-12 00:44:38]

http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h
File src/ibuskeys.h (right):

http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h#newcode53
src/ibuskeys.h:53: guint            ibus_unicode_to_keyval (guint32         wc);
On 2011/08/11 14:45:39, Yusuke Sato wrote:
> How about copying or moving the function comment in ibuskeyuni.c to this file?

> 
> Since the return value of the function is actually confusing, I guess it's
> better to have a clear documentation here.

Done.

[Yusuke Sato, 2011-08-12 01:06:43]

lgtm

On 2011/08/12 00:44:38, Peng wrote:
> http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h
> File src/ibuskeys.h (right):
> 
> http://codereview.appspot.com/4870042/diff/1/src/ibuskeys.h#newcode53
> src/ibuskeys.h:53: guint            ibus_unicode_to_keyval (guint32        
wc);
> On 2011/08/11 14:45:39, Yusuke Sato wrote:
> > How about copying or moving the function comment in ibuskeyuni.c to this
file?
> 
> > 
> > Since the return value of the function is actually confusing, I guess it's
> > better to have a clear documentation here.
> 
> Done.