Refactor CheckAddressOfOperand()

Committed at 138987

[Sean Hunt, 2011-08-09 22:56:40]

I'm not sure about the need for this one. There's nothing ostensibly wrong with
it, but you're refactoring out one line; I think it's preferable just to leave
the diagnostic expressions where they are unless there's some other reason you
want to factor them out.

[rtrieu, 2011-08-11 03:29:46]

On 2011/08/09 22:56:40, Sean Hunt wrote:
> I'm not sure about the need for this one. There's nothing ostensibly wrong
with
> it, but you're refactoring out one line; I think it's preferable just to leave
> the diagnostic expressions where they are unless there's some other reason you
> want to factor them out.

The main point is to reduce the number of places that a diagnostic is emitted
from, in case we need to change the diagnostic later.

[Sean Hunt, 2011-08-11 03:32:12]

On Wed, Aug 10, 2011 at 20:29,  <rtrieu@google.com> wrote:
> The main point is to reduce the number of places that a diagnostic is
> emitted from, in case we need to change the diagnostic later.

I suppose that makes sense. I'd double-check with Doug on these though.

Sean