Issue 4856049: Reduce duplicate code in pointer comparisons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4856049: Reduce duplicate code in pointer comparisons (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by rtrieu

Modified:
13 years, 5 months ago

Reviewers:
Sean Hunt

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Patch Set 2 : Fix bad comment and pick a better function name #

Patch Set 3 : Update base file and invert return type for check function. #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -72 lines)			Patch
	M	lib/Sema/SemaExpr.cpp	View	1 2	7 chunks	+84 lines, -72 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sean Hunt

http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp File lib/Sema/SemaExpr.cpp (right): http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp#newcode6169 lib/Sema/SemaExpr.cpp:6169: /// \brief Returns true if the member pointers are ...

13 years, 5 months ago (2011-08-09 23:18:40 UTC) #1

rtrieu

13 years, 5 months ago (2011-08-10 21:52:31 UTC) #2

http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp
File lib/Sema/SemaExpr.cpp (right):

http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp#newcode6169
lib/Sema/SemaExpr.cpp:6169: /// \brief Returns true if the member pointers are
compatible.
On 2011/08/09 23:18:40, Sean Hunt wrote:
> This function doesn't necessarily run on member pointers, right?

Done.

http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp#newcode6172
lib/Sema/SemaExpr.cpp:6172: ExprResult &rex) {
On 2011/08/09 23:18:40, Sean Hunt wrote:
> A function named 'check' shouldn't have side effects on its operands. These
> should at least be documented, and it would be good to find a better name.

Done.

http://codereview.appspot.com/4856049/diff/1/lib/Sema/SemaExpr.cpp#newcode6216
lib/Sema/SemaExpr.cpp:6216: static void
diagnoseFunctionPointerToVoidComparison(Sema &S, SourceLocation Loc,
On 2011/08/09 23:18:40, Sean Hunt wrote:
> And this one.

What's wrong with this one?

Expand All Messages | Collapse All Messages