Issue 4855046: Port change r2040 to mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4855046: Port change r2040 to mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by arthurhsu

Modified:
13 years, 4 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Port change r2040 to mac This is to honor fixed width font during PDF generation. Change r2040 fixed only Windows port. Linux does not have the problem.

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Chris Guillory

LGTM. Can you remove the BUG= and TEST= and your message about committing from the ...

13 years, 4 months ago (2011-08-08 23:19:26 UTC) #2

arthurhsu

On 2011/08/08 23:19:26, Chris Guillory wrote: > LGTM. Can you remove the BUG= and TEST= ...

13 years, 4 months ago (2011-08-08 23:22:49 UTC) #3

Chris Guillory

13 years, 4 months ago (2011-08-08 23:23:57 UTC) #4

Committed as revision 2076. Please close this issue.

Expand All Messages | Collapse All Messages