Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(841)

Issue 4853046: Rename all __gl_ functions to Sk__gl_ to avoid conflicting with other copies

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by scottmg
Modified:
13 years, 1 month ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/third_party/glu/
Visibility:
Public.

Description

Rename all __gl_ functions to Sk__gl_ to avoid conflicting with other copies of libtess that might be statically linked by Skia clients (done via gluos.h, rather that touching source directly). Specfically, this is required to enable incremental linking on Windows builds of Chromium because WebKit has a copy of libtess also. Previously http://codereview.appspot.com/4536080/ and http://trac.webkit.org/changeset/87178 but go a bit farther because the internal __gl_ functions collide with incremental linking because .objs are linked directly, rather than via .lib http://code.google.com/p/chromium/issues/detail?id=92172 http://code.google.com/p/skia/issues/detail?id=338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M README.skia View 1 chunk +3 lines, -0 lines 0 comments Download
M gluos.h View 1 chunk +48 lines, -0 lines 0 comments Download
M libtess/dict.h View 1 chunk +2 lines, -0 lines 0 comments Download
M libtess/memalloc.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
scottmg
13 years, 1 month ago (2011-08-10 00:00:31 UTC) #1
Stephen White
Medium-term, we plan to remove the copy of libtess in WebKit, which should eliminate the ...
13 years, 1 month ago (2011-08-10 13:55:11 UTC) #2
scottmg
On 2011/08/10 13:55:11, Stephen White wrote: > Medium-term, we plan to remove the copy of ...
13 years, 1 month ago (2011-08-10 14:24:39 UTC) #3
Stephen White
13 years, 1 month ago (2011-08-10 17:49:58 UTC) #4
On 2011/08/10 14:24:39, scottmg wrote:
> On 2011/08/10 13:55:11, Stephen White wrote:
> > Medium-term, we plan to remove the copy of libtess in WebKit, which should
> > eliminate the need for all this renaming.
> > 
> > But this LGTM for now.
> 
> OK, thanks. Would you mind doing the commit? (assuming no one else objects to
> the change)

Landed as r2095.  Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b