Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12514)

Issue 48530043: Issue 3777: Code improvements in satb.ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by Trevor Daniels
Modified:
9 years, 1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3777: Code improvements in satb.ly Comment out \version to ensure user still sees a warning if he omits one Add prefix to macro and function names to avoid potential clashes with user names Return *unspecified* if macros are called with an undefined argument rather than #{#} Remove unnecessary use of "identity" Use "and" rather than "if" when false condition would return #f Convert tabs to spaces Use $ rather than # in \layout

Patch Set 1 #

Patch Set 2 : Comment out \version #

Patch Set 3 : Return \layout to original state #

Patch Set 4 : Setting Layout now works #

Patch Set 5 : Rebase on current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -78 lines) Patch
M ly/satb.ly View 1 2 3 4 7 chunks +79 lines, -78 lines 0 comments Download

Messages

Total messages: 6
Trevor Daniels
Comment out \version
10 years, 3 months ago (2014-01-08 11:53:22 UTC) #1
Trevor Daniels
Return \layout to original state
10 years, 3 months ago (2014-01-08 14:32:49 UTC) #2
Trevor Daniels
Setting Layout now works
10 years, 3 months ago (2014-01-09 14:27:04 UTC) #3
Trevor Daniels
This patch has been superseded by an improved version provided by Devon Schudy (see Issue ...
10 years, 3 months ago (2014-01-14 00:11:11 UTC) #4
Trevor Daniels
Rebase on current master
9 years, 1 month ago (2015-03-07 23:34:48 UTC) #5
Trevor Daniels
9 years, 1 month ago (2015-03-12 15:33:38 UTC) #6
Message was sent while issue was closed.
Pushed to staging as
7225065e1958c770f4e450ebc6f32366afd78a83

Author: Trevor Daniels <t.daniels@treda.co.uk>  2015-03-07 22:45:00
Committer: Trevor Daniels <t.daniels@treda.co.uk>  2015-03-12 15:26:48

    Issue 3777: Code improvements in satb.ly
    
      Comment out the \version statement to ensure
      users still are warned if they omit their own
      \version statement
    
      Add prefix to macro and function names to avoid
      potential clashes with user names
    
      Return *unspecified* if macros are called with
      an undefined argument rather than #{#}
    
      Remove unnecessary use of "identity"
    
      Use "and" rather than "if" when false condition
      would return #f
    
      Convert tabs to spaces
    
      Use $ rather than # in \layout

Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b