Issue 4850051: Doc: NR Warning added to para for cueduring

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4850051: Doc: NR Warning added to para for cueduring (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by pkx166h

Modified:
12 years, 7 months ago

Reviewers:
Keith, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Doc: NR Warning added to para for cueduring As per Tracker 1811. Added @warning{ } around pararaph in cueDuring to alert users to create explicit contexts in certain cases.

Patch Set 2 : Second Draft #

Total comments: 1

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	Documentation/notation/staff.itely	View	1	1 chunk	+4 lines, -3 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Trevor Daniels

LGTM, with a tweak as suggested below to explain why. http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely#newcode1304 ...

12 years, 8 months ago (2011-08-09 23:08:15 UTC) #1

pkx166h

Second draft, James http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely#newcode1304 Documentation/notation/staff.itely:1304: @warning{In this example, the @code{Voice} context ...

12 years, 8 months ago (2011-08-10 21:39:12 UTC) #2

Keith

12 years, 8 months ago (2011-08-17 18:58:05 UTC) #4

LGTM.
Recently the same issue came up with \quoteDuring  
<http://lists.gnu.org/archive/html/bug-lilypond/2011-08/msg00425.html>
(that bug report has other issues as well)

That is, starting a Staff with a quote prints nothing.
  \addQuote "A" {c' d' e' f' c' d' e' f'}
  \new Staff{ \quoteDuring "A" s1  r1}
Could you add a parallel warning to the \quoteDuring section?

http://codereview.appspot.com/4850051/diff/3001/Documentation/notation/staff....
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/4850051/diff/3001/Documentation/notation/staff....
Documentation/notation/staff.itely:1181: 
Same issue as with \cueDuring, happens with \quoteDuring

When a @code{Voice} starts with @code{\quoteDuring} the @code{Voice} context
must be explicitly declared.

Expand All Messages | Collapse All Messages