Issue 4850043: Fixes for iOS / Ganesh

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4850043: Fixes for iOS / Ganesh

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by bsalomon

Modified:
14 years ago

Reviewers:
yangsu

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : add back old stencil clear behavior when sb > rt #

Patch Set 3 : comment / whitespace cleanup #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -68 lines)			Patch
M	gpu/include/GrGpu.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLProgram.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1 2	1 chunk	+9 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	1 2	4 chunks	+69 lines, -64 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

14 years ago (2011-08-05 15:45:03 UTC) #3

New patch still doesn't work because it compares the unbloated RT dimensions
against the bloated SB dimensions and so takes the stencil-only fbo path (which
doesn't work on iOS).

Will submit the original patch for now.

Expand All Messages | Collapse All Messages