Honor fixed width font in Windows.

Honor fixed width font in Windows.

BUG=none
TEST=none

[arthurhsu, 2011-08-03 22:57:03]

Fix Windows font host not honoring fixed width fonts.  Resulting ~20KB savings
each fixed width font in generated PDF.

[Chris Guillory, 2011-08-03 23:10:39]

LGTM. Can you have Steve have a look? Do we need to fix this for the other
platforms? Perhaps he knows.

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:258: SkScalar	 fScale;	// to get from canonical
size to real size
Can you remove the all tab characters from this line.

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:825: if (!(otm.otmTextMetrics.tmPitchAndFamily &
TMPF_FIXED_PITCH)) {
Optional: Perhaps you can check info->fStyle against
SkAdvancedTypefaceMetrics::kFixedPitch_Style that's set above.

[arthurhsu, 2011-08-03 23:27:23]

I double checked the Linux host and it does not have the problem.

The Mac host has same issue.  I'd suggest doing a separate CL.

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:258: SkScalar	 fScale;	// to get from canonical
size to real size
On 2011/08/03 23:10:39, Chris Guillory wrote:
> Can you remove the all tab characters from this line.

Done.

http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:825: if (!(otm.otmTextMetrics.tmPitchAndFamily &
TMPF_FIXED_PITCH)) {
On 2011/08/03 23:10:39, Chris Guillory wrote:
> Optional: Perhaps you can check info->fStyle against
> SkAdvancedTypefaceMetrics::kFixedPitch_Style that's set above.

Done.

[Chris Guillory, 2011-08-03 23:41:30]

SGTM

On Wed, Aug 3, 2011 at 4:27 PM, <arthurhsu@chromium.org> wrote:

> I double checked the Linux host and it does not have the problem.
>
> The Mac host has same issue.  I'd suggest doing a separate CL.
>
>
>
> http://codereview.appspot.com/**4850041/diff/1002/src/ports/**
>
SkFontHost_win.cpp<http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp>
> File src/ports/SkFontHost_win.cpp (right):
>
> http://codereview.appspot.com/**4850041/diff/1002/src/ports/**
>
SkFontHost_win.cpp#newcode258<http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#newcode258>
> src/ports/SkFontHost_win.cpp:**258: SkScalar       fScale;        // to
> get from
> canonical size to real size
> On 2011/08/03 23:10:39, Chris Guillory wrote:
>
>> Can you remove the all tab characters from this line.
>>
>
> Done.
>
>
> http://codereview.appspot.com/**4850041/diff/1002/src/ports/**
>
SkFontHost_win.cpp#newcode825<http://codereview.appspot.com/4850041/diff/1002/src/ports/SkFontHost_win.cpp#newcode825>
> src/ports/SkFontHost_win.cpp:**825: if
> (!(otm.otmTextMetrics.**tmPitchAndFamily & TMPF_FIXED_PITCH)) {
> On 2011/08/03 23:10:39, Chris Guillory wrote:
>
>> Optional: Perhaps you can check info->fStyle against
>> SkAdvancedTypefaceMetrics::**kFixedPitch_Style that's set above.
>>
>
> Done.
>
>
>
http://codereview.appspot.com/**4850041/<http://codereview.appspot.com/4850041/>
>

[arthurhsu, 2011-08-04 00:19:24]

I'm not a committer, can you help to commit this change?  Thanks.

[Chris Guillory, 2011-08-04 01:02:19]

Committed as revision 2040. Can you close this issue since I can not?