Issue 4844062: Removed compiler/unistd.h reference from build_angle.gyp.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4844062: Removed compiler/unistd.h reference from build_angle.gyp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by apatrick1

Modified:
12 years, 9 months ago

Reviewers:
Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Removed compiler/unistd.h reference from build_angle.gyp. Committed: http://code.google.com/p/angleproject/source/detail?r=725

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/build_angle.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Alok Priyadarshi

lgtm If it is not being included in the source files, would you also "svn ...

12 years, 9 months ago (2011-08-10 22:06:56 UTC) #2

apatrick1

12 years, 9 months ago (2011-08-10 22:19:16 UTC) #3

On 2011/08/10 22:06:56, Alok Priyadarshi wrote:
> lgtm
> 
> If it is not being included in the source files, would you also "svn delete"
the
> file?

I removed the reference from the gyp file because that file does not exist and
the latest gclient now complains about it.

Expand All Messages | Collapse All Messages